Open
Conversation
After modifying offset, it moves turret to the updated position using the offset.
codeNinja-1
requested changes
Mar 20, 2026
Still some major issues, but it's an improvement
we had to change the return type of setOffsetAngle to void instead of Command so that it constantly updates the input parameter newOffset
If autoshoot is consistently off, the operator can use manual offset to change it
removed some unnecessary code from TeleopControls very unremarkable
Switched with climb. Makes more sense with turret.
codeNinja-1
requested changes
Mar 29, 2026
… target angle supplier, and removed the print statements in the manual offset commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added manual offset and refresh to adjust position for accuracy. It is a manual turret correction