Skip to content

Pr 149#439

Merged
svanteschubert merged 4 commits intomasterfrom
pr-149
Apr 10, 2026
Merged

Pr 149#439
svanteschubert merged 4 commits intomasterfrom
pr-149

Conversation

@xzel23
Copy link
Copy Markdown
Collaborator

@xzel23 xzel23 commented Apr 10, 2026

fixed module definitions, added a modular smoketest, fixed build errors.

@sonarqubecloud
Copy link
Copy Markdown

@xzel23
Copy link
Copy Markdown
Collaborator Author

xzel23 commented Apr 10, 2026

@svanteschubert I play this back to you. I made some changes to make build and tests pass and added a very simple modular smoketest. Please review and let's get this in.

@xzel23 xzel23 requested a review from svanteschubert April 10, 2026 12:48
Copy link
Copy Markdown
Contributor

@svanteschubert svanteschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a step forward!
Thank you for your contribution.
We might still adjust if there is any solution that avoids the build warning now:

[INFO] --- compiler:3.12.0:compile (default-compile) @ odfdom-java --- [WARNING] ******************************************************************************************************************************************************************************************************************************************************* [WARNING] * Required filename-based automodules detected: [xercesImpl-2.12.2.jar, serializer-2.7.3.jar, java-rdfa-1.0.0-BETA1.jar, commons-digester-2.1.jar, commons-collections-3.2.2.jar]. Please don't publish this project to a public artifact repository! * [WARNING]

Still much better than the status quo!
Thanks, Axel!
Svante

@svanteschubert svanteschubert merged commit cfd3a9f into master Apr 10, 2026
7 checks passed
@svanteschubert svanteschubert deleted the pr-149 branch April 10, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants