Conversation
|
|
@svanteschubert I play this back to you. I made some changes to make build and tests pass and added a very simple modular smoketest. Please review and let's get this in. |
svanteschubert
left a comment
There was a problem hiding this comment.
This is definitely a step forward!
Thank you for your contribution.
We might still adjust if there is any solution that avoids the build warning now:
[INFO] --- compiler:3.12.0:compile (default-compile) @ odfdom-java --- [WARNING] ******************************************************************************************************************************************************************************************************************************************************* [WARNING] * Required filename-based automodules detected: [xercesImpl-2.12.2.jar, serializer-2.7.3.jar, java-rdfa-1.0.0-BETA1.jar, commons-digester-2.1.jar, commons-collections-3.2.2.jar]. Please don't publish this project to a public artifact repository! * [WARNING]
Still much better than the status quo!
Thanks, Axel!
Svante



fixed module definitions, added a modular smoketest, fixed build errors.