jextract/jni: Propagate generic parameters to Case types of generic enums#765
Open
sidepelican wants to merge 3 commits into
Open
jextract/jni: Propagate generic parameters to Case types of generic enums#765sidepelican wants to merge 3 commits into
sidepelican wants to merge 3 commits into
Conversation
sidepelican
commented
May 23, 2026
Collaborator
|
Oh too bad to hear you won’t have more time contributing … maybe in some hobby time :-) Thanks for all the contributions, it’s all accounted for very useful improvements! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first step toward supporting the extraction of generic associated values from generic enum.
Currently, the generated
Casetypes for generic enums do not carry generic parameters.While this isn't causing immediate issues, these parameters will be necessary in the future when we want to extract generic associated values from the
Case.This PR focuses solely on propagating the generic parameters of the enum type down to its
Casetype.During this work, I encountered and fixed an issue in wrap-java where translation was failing when a nested type's parent type was generic.
Note
I have loved contributing to
swift-javafor a half year, but unfortunately, I have run out of time to continue doing so.While I will keep following the development of
swift-java, I won't be able to actively contribute as I did before.Thank you so much for all your valuable code reviews.