fixed pylint issues for installer/helper.py#1222
Open
abhi-jeet-kumar wants to merge 1 commit intosukeesh:masterfrom
Open
fixed pylint issues for installer/helper.py#1222abhi-jeet-kumar wants to merge 1 commit intosukeesh:masterfrom
abhi-jeet-kumar wants to merge 1 commit intosukeesh:masterfrom
Conversation
pnhofmann
reviewed
Dec 7, 2024
| Represents the result of a shell command. | ||
| """ | ||
| def __init__(self, success, output='', exception=None): | ||
| self.success = success |
Collaborator
There was a problem hiding this comment.
This crashes the installer script
Logging to /tmp/tmph34fnn9o
==================================================
Preparing virtualenv
==================================================
|
An unexpected error occurred. Please open an issue on github!
here is the error:
Traceback (most recent call last):
File "/home/phil/Jarvis/installer/__main__.py", line 11, in <module>
import steps.a_setup_virtualenv
File "/home/phil/Jarvis/installer/steps/a_setup_virtualenv.py", line 17, in <module>
if not py3_installed.success() or not py3_installed.cli_output.startswith('Python 3'):
^^^^^^^^^^^^^^^^^^^^^^^
TypeError: 'bool' object is not callable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for issues : 1217