feat(crypto): enabled the use of certificate/key pairs from disk vs. …#66
feat(crypto): enabled the use of certificate/key pairs from disk vs. …#66jinncoder wants to merge 4 commits intosubspacecommunity:masterfrom
Conversation
…just using letsencrypt - issue#20
jack1902
left a comment
jack1902
left a comment
There was a problem hiding this comment.
LGTM, just need to remove the os.Exit calls after a log.Fatal https://golang.org/src/log/log.go?s=10156:10184#L320
gavinelder
left a comment
gavinelder
left a comment
There was a problem hiding this comment.
I need to do a more in-depth review locally but have addressed some initial concerns.
|
|
||
| // Plain text web server for use behind a reverse proxy. | ||
| if !letsencrypt { | ||
| if !letsencrypt && tlsCertificate == "" || tlsKey == "" { |
There was a problem hiding this comment.
| if !letsencrypt && tlsCertificate == "" || tlsKey == "" { | |
| if !letsencrypt || tlsCertificate == "" || tlsKey == "" { |
There was a problem hiding this comment.
when:
le == false
kp == true
(!le || kp) then pass (which we don't want, correct?)
when:
le == false
kp == true
(!le && cert) then fail (which is what we want, no?)
So it should stay a && and not be changed to a || - or am I missing it?
| httpsd := &http.Server{ | ||
| Handler: r, | ||
| Addr: httpAddr, | ||
| WriteTimeout: httpTimeout, | ||
| ReadTimeout: httpTimeout, | ||
| MaxHeaderBytes: maxHeaderBytes, | ||
| } | ||
|
|
There was a problem hiding this comment.
I need to check out the PR on my own machine but this looks like it's in the wrong place.
|
It's been a few days - any other issues which need be resolved before merging? |
|
Is there a possibility this might get merged soon? |
|
Kudos, SonarCloud Quality Gate passed!
|
4 participants
enabled the use of certificate/key pairs from disk vs. just using let's encrypt - issue#20
to:
cc: @subspacecommunity/subspace-maintainers
related to:
resolves: #20
Background
Requested in #20
Changes
Testing
Steps for how this change was tested and verified
Generate a certificate/key pair in PEM format and try it out on the command line: