Track pyspec procedure names for targeted inlining#729
Closed
MikaelMayer wants to merge 18 commits intomainfrom
Closed
Track pyspec procedure names for targeted inlining#729MikaelMayer wants to merge 18 commits intomainfrom
MikaelMayer wants to merge 18 commits intomainfrom
Conversation
PySpec procedures are now explicitly tracked by name through the pipeline so that inlining targets only pyspec-originating procedures rather than relying on heuristics (non-main, non-prelude). - Add pyspecProcedureNames field to PySpecLaurelResult - Add PyAnalyzeResult struct returned by pyAnalyzeLaurel - Inlining predicate uses pyspecProcedureNames instead of file count gate - Update all callers: StrataMain, SimpleAPI, AnalyzeLaurelTest, TestExamples
Callers no longer need to manually construct the inlining predicate. Both StrataMain and AnalyzeLaurelTest now call inlinePySpecProcedures.
MikaelMayer
commented
Apr 1, 2026
- Prefix unused preludeNames with underscore in StrataMain - Call inlinePySpecProcedures in pyTranslateLaurel so all pipelines get automatic pyspec inlining - Add clarifying comment on seenProcs fold
Contributor
Author
|
Addressed all three review comments:
|
Contributor
Author
|
This PR is not adding anything significant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track pyspec procedure names for targeted inlining
Previously, pyspec procedure inlining was gated on whether
--pyspecflags were passed on the CLI, and when triggered, it inlined all non-main, non-prelude procedures indiscriminately. Tests also had to manually construct the inlining predicate.This PR tracks which procedure names originate from pyspec files through the pipeline and provides
inlinePySpecProceduresso callers don't need to know the inlining details.Changes
PySpecLaurelResultgains apyspecProcedureNamesfield, populated duringbuildPySpecLaurelpyAnalyzeLaurelreturns aPyAnalyzeResultstruct containing both the Laurel program and the pyspec procedure namesinlinePySpecProceduresencapsulates the inlining logic — callers just pass the Core program and the pyspec namesTesting
Existing
AnalyzeLaurelTesttests pass — these exercise the full pyspec dispatch + inlining + verification pipeline.