#503 Remove unnecessary tests for preprocessor directives.#504
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #504 +/- ##
==========================================
- Coverage 92.21% 92.21% -0.01%
==========================================
Files 87 87
Lines 13832 13831 -1
==========================================
- Hits 12755 12754 -1
Misses 1077 1077 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small performance optimisation for parsing preprocessor directives. Originally, utils.c would test each cpp directive individually. With this small change, it will first see if the line actually starts with "#" before triggering these tests, which can greatly reduce the number of unnecessary tests.
I also moved matching of preprocessor lines after the test for
endcls(since it should be more likely for any code to match the expected end directive than a preprocessor directives, which are all in all rather rare), which shaves of another 500 or so tests for one lfric example.