ci: fix Maven GPG import input name#182
Merged
Merged
Conversation
crazy-max/ghaction-import-gpg@v7 expects 'gpg_private_key' (underscore); the workflow used 'gpg-private-key' (hyphen), which was silently ignored and caused 'Input required and not supplied: gpg_private_key', failing the Maven Central release for 1.5.0-RC2.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
release-mavenjob in the1.5.0-RC2release failed at the Import PGP key step:crazy-max/ghaction-import-gpg@v7expects the inputgpg_private_key(underscore). The workflow passedgpg-private-key(hyphen), which was silently ignored, so the required key was never supplied and the step errored before the Maven deploy ran. (TheSFIO_PGP_PRIVATE_KEYsecret itself is fine — the value was present but bound to an unrecognized input name.)Fix
Rename the input
gpg-private-key→gpg_private_key.passphrasewas already correct.Note
crates.io, NuGet, and docs all published successfully for 1.5.0-RC2; only Maven Central and the dependent GitHub release were blocked. After this merges, the
1.5.0-RC2tag needs to be re-pointed at the fixed commit and re-pushed to re-run the pipeline (the crates.io/NuGet jobs skip if the version already exists).