fix update strategy default handling#1179
Open
Zakharden wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1179 +/- ##
===========================================
- Coverage 62.36% 30.88% -31.48%
===========================================
Files 197 239 +42
Lines 4854 6550 +1696
===========================================
- Hits 3027 2023 -1004
- Misses 1439 4351 +2912
+ Partials 388 176 -212
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Zakharden
force-pushed
the
fix/rolling-update-default-strategy
branch
3 times, most recently
from
72295c7 to
60bbb71
Compare
Zakharden
force-pushed
the
fix/rolling-update-default-strategy
branch
from
60bbb71 to
59c6b27
Compare
Signed-off-by: Zakhar Dvurechensky <72825626+Zakharden@users.noreply.github.com>
Author
|
I see this as code-complete on the branch and currently blocked only by maintainer flow. Please re-run checks/review and let me know if anything else is required. |
Zakharden
force-pushed
the
fix/rolling-update-default-strategy
branch
from
59c6b27 to
6dd3f0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes false positive for omitted rolling update strategy. Validation: go test ./pkg/templates/updateconfig, git diff --check.