fix: configure requests to use CA for Pulp#2316
Open
jackhodgkiss wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several Ansible playbooks to support pulp_enable_tls by configuring the REQUESTS_CA_BUNDLE environment variable for various Pulp-related tasks. It introduces logic to determine the appropriate CA bundle path based on the OS family and ensures fact gathering is enabled where required. The review feedback suggests improving maintainability by deduplicating the CA bundle variable logic into a central configuration file, using the | bool filter for more robust evaluation of the pulp_enable_tls variable, and moving environment blocks to the play level to reduce repetition.
The `Pulp` playbooks used at client sites can fail when `Pulp` is configured to use TLS with certificates generated by our internal `TLS` process in combination with the newer `Pulp` collection and tools. Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
jackhodgkiss
force-pushed
the
pulp-tls-ca-fix
branch
from
037c728 to
b866dcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Pulpplaybooks used at client sites can fail whenPulpis configured to use TLS with certificates generated by our internalTLSprocess in combination with the newerPulpcollection and tools.