chore: Describe RBAC rules, remove unnecessary rules#693
Draft
NickLarsenNZ wants to merge 2 commits intomainfrom
Draft
chore: Describe RBAC rules, remove unnecessary rules#693NickLarsenNZ wants to merge 2 commits intomainfrom
NickLarsenNZ wants to merge 2 commits intomainfrom
Conversation
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#798
Note
This was initially generated by a coding assistant to see how well it can inspect code and review the RBAC rules. the changes will be properly checked before reviews are requested.
Permissions removed
""(core)configmapsget,list,watchconfigmapswas already covered by an earlier rule grantingcreate,patch,get,watch,listsecrets.stackable.techtruststorescreate,patch(conditional)SecretClassis applied at startup, not a defaultTrustStorePermissions retained (with justification)
apiextensions.k8s.iocustomresourcedefinitionscreate,patch,list,watchmaintenance.customResourceDefinitions.maintain.""(core)secretsget,list,watch,create,patch,updatereplace()= HTTP PUT requiresupdate), kerberosKeytab, k8sSearch, certManager backends and truststore controller""(core)eventsget,list,watch,create,patch,updateexternal-provisionersidecar container (same ServiceAccount), which uses the legacy core/v1 events API includingupdate""(core)configmapscreate,patch,get,watch,list.owns()/.watches(). Also read by autoTLS (additional trust roots) and k8sSearch (trust-store ConfigMap)""(core)persistentvolumesget,list,watch,patch,create,deleteexternal-provisionersidecar container, not the operator binary directly""(core)nodesget,list,watchlist/watchalso needed by the external-provisioner sidecar for topology""(core)persistentvolumeclaimsget,list,watchCreateVolumeto locate the owning Pod and resolve listener scope; also needed by the external-provisioner sidecar""(core)nodes/proxyget""(core)podsget,patchstorage.k8s.iocsinodesget,list,watchstorage.k8s.iostorageclassesget,list,watchsecrets.stackable.techsecretclassesget,watch,list(+ conditionalcreate,patch).watches_stream()and read inreconcile().create/patch(when CRD maintenance is enabled) deploys the defaulttlsSecretClasssecrets.stackable.techtruststoresget,watch,listController::newwatches this typelisteners.stackable.techlistenerclasses,listeners,podlistenersgetcert-manager.iocertificatesget,patch,createevents.k8s.ioeventscreate,patchsecurity.openshift.iosecuritycontextconstraintsuseBidirectionalmount propagation)Notes
ClusterRoleandServiceAccountshared between the controllerDeploymentand the CSI nodeDaemonSet(including theexternal-provisionersidecar). Several permissions are required solely by sidecar containers rather than the operator binary itself.updateonsecretsis non-obvious: the autoTLS CA rotation code uses the kube entry API, which callsreplace()(HTTP PUT) on existing entries — Server-Side Apply (patch) is not sufficient here.updateonevents(core v1) is for theexternal-provisionersidecar, not the operator. The operator usesevents.k8s.ioexclusively.