Conversation
egg-zz
added
🌊 squad-__init__
preview
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increases the maximum height of the plagiarism cluster dialog and refactors the manual invitation component to integrate the direct domain input field into the select trigger. Feedback highlights that nesting an input within a button-based trigger is invalid HTML and suggests improvements for accessibility and event handling, such as adding onKeyDown propagation and autoFocus. Additionally, it is recommended to add overflow-y-auto to the dialog content to prevent visual bleeding when content exceeds the maximum height.
| <Dialog open={open} onOpenChange={handleOpenChange}> | ||
| <DialogContent | ||
| className="flex max-h-[85vh] max-w-4xl flex-col" | ||
| className="flex max-h-[90vh] max-w-4xl flex-col" |
There was a problem hiding this comment.
Increasing the max-height helps, but to fully resolve the issue where the list is visible outside the modal (as mentioned in the PR description), it is recommended to add overflow-y-auto to the DialogContent. This ensures that if the content exceeds the maximum height, it will scroll internally instead of bleeding out.
className="flex max-h-[90vh] max-w-4xl flex-col overflow-y-auto"
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
1 participant
Description
표절 검사의 페이지네이션이 제대로 되지 않아 모달 밖까지 list가 보이는 문제를 수정합니다
stage에서도 표절 검사를 진행해보았으나 graphql에서 대기 중이 떠 일단 모달의 max-h를 늘리는 방향으로 수정했습니다.
표절 검사 진행을 위해 invite manually를 하던 도중 Enter directly의 위치가 input field 밖에 존재하는 것 확인했습니다. 해당 사항도 함께 수정했습니다
instructor 계정 -> management -> course -> 정우진개론 -> assignment -> PA -> plagiarism 탭 -> 문제 A
Additional context
Before submitting the PR, please make sure you do the following
fixes #123).closes TAS-2666