Update the ClearML health check to ensure that the autoscaler is operational#896
Update the ClearML health check to ensure that the autoscaler is operational#896pmachapman wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #896 +/- ##
==========================================
- Coverage 67.98% 67.87% -0.12%
==========================================
Files 386 386
Lines 21224 21256 +32
Branches 2740 2749 +9
==========================================
- Hits 14429 14427 -2
- Misses 5810 5844 +34
Partials 985 985 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enkidu93
left a comment
There was a problem hiding this comment.
Have you confirmed that this works - at least that the apps.get_instances call responds properly under normal conditions?
@Enkidu93 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
pmachapman
left a comment
There was a problem hiding this comment.
Have you confirmed that this works - at least that the
apps.get_instancescall responds properly under normal conditions?
@Enkidu93 Yes, I stepped through it both when an e2e test was running (and so using the autoscaler), and when no e2e test was running (and so there were no workers for the autoscaler).
@pmachapman made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
Enkidu93
left a comment
There was a problem hiding this comment.
Great! Thank you.
@Enkidu93 made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
Fixes #584
This change is