You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @siddharthkp, seems like Travis CI builds are failing because of an authentication issue in Travis CI. Is that github_token env being set? Does it need to be updated?
The test.js script was also hardcoded to read only from your own repo, as opposed to the repo it resided in, so it's been updated now. New PR forks should be able to pass now if they set it up on their end.
I also noticed that the package-lock.json was out of sync from your dependency versions, so I updated it. Now the Node test on Travis CI will pass.
As an aside, I've added you as a collaborator on my fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't take over PR #5 without being a maintainer on this repo or that PR, so I've started a new one.
This should fix #3.
build.domainandbuild.prefix