Skip to content

Allow GitHub Enterprise domains#11

Closed
JimmyMultani wants to merge 11 commits into
siddharthkp:masterfrom
JimmyMultani:master
Closed

Allow GitHub Enterprise domains#11
JimmyMultani wants to merge 11 commits into
siddharthkp:masterfrom
JimmyMultani:master

Conversation

@JimmyMultani
Copy link
Copy Markdown

@JimmyMultani JimmyMultani commented May 15, 2020

Can't take over PR #5 without being a maintainer on this repo or that PR, so I've started a new one.

This should fix #3.

  • update script to read from build.domain and build.prefix
  • update docs for new parameters
  • update tests to read from travis ci envs

@JimmyMultani
Copy link
Copy Markdown
Author

JimmyMultani commented May 15, 2020

Hey @siddharthkp, seems like Travis CI builds are failing because of an authentication issue in Travis CI. Is that github_token env being set? Does it need to be updated?

The test.js script was also hardcoded to read only from your own repo, as opposed to the repo it resided in, so it's been updated now. New PR forks should be able to pass now if they set it up on their end.

I also noticed that the package-lock.json was out of sync from your dependency versions, so I updated it. Now the Node test on Travis CI will pass.

As an aside, I've added you as a collaborator on my fork.

@JimmyMultani JimmyMultani marked this pull request as ready for review May 15, 2020 04:16
@JimmyMultani
Copy link
Copy Markdown
Author

Hey @siddharthkp, would love to hear your feedback on this.

@JimmyMultani
Copy link
Copy Markdown
Author

@siddharthkp, it doesn't seem like this is what you're looking for. Just let me know and I'll close the request, or you can close it yourself. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Github Enterprise

2 participants