[Fix #1286] Non blocking persistence

[fjtirado]

Fix #1286

[fjtirado]

This will create backward incompatibility on qflow when released, but I guess it is acceptable (we are swithcing to AsyncPersistenceExceutor

[Copilot]

Pull request overview

Implements non-blocking persistence by moving workflow lifecycle listeners to a CompletableFuture-based contract and switching default persistence execution to async.

Changes:

• Introduces WorkflowExecutionCompletableListener and adapts existing WorkflowExecutionListener implementations via an adapter.
• Refactors lifecycle event publishing to return/compose CompletableFutures rather than fire-and-forget.
• Updates persistence executors/writers to use a unified execute(...) path and defaults to AsyncPersistenceExecutor.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
impl/persistence/api/src/main/java/io/serverlessworkflow/impl/persistence/WorkflowPersistenceListener.java	Migrates persistence listener callbacks to return CompletableFuture for async persistence writes.
impl/persistence/api/src/main/java/io/serverlessworkflow/impl/persistence/WorkflowPersistenceInstance.java	Adjusts async control flow in start() to return a CompletableFuture from a callback.
impl/persistence/api/src/main/java/io/serverlessworkflow/impl/persistence/TransactedPersistenceInstanceWriter.java	Uses PersistenceExecutor.execute(...) uniformly (removes start/delete special-casing).
impl/persistence/api/src/main/java/io/serverlessworkflow/impl/persistence/SyncPersistenceExecutor.java	Removes synchronous executor implementation.
impl/persistence/api/src/main/java/io/serverlessworkflow/impl/persistence/PersistenceExecutor.java	Simplifies executor API by removing startInstance/deleteInstance defaults.
impl/persistence/api/src/main/java/io/serverlessworkflow/impl/persistence/DefaultPersistenceInstanceHandlers.java	Defaults persistence execution to AsyncPersistenceExecutor when none provided.
impl/persistence/api/src/main/java/io/serverlessworkflow/impl/persistence/AsyncPersistenceExecutor.java	Makes async executor publicly constructible and adds a no-arg constructor.
impl/persistence/api/src/main/java/io/serverlessworkflow/impl/persistence/AbstractAsyncPersistenceExecutor.java	Reworks async execution implementation (removes per-instance chaining/close drain).
impl/core/src/test/java/io/serverlessworkflow/impl/WorkflowListenerTest.java	Updates tests to use the new completable listener type.
impl/core/src/test/java/io/serverlessworkflow/impl/TopPriorityListener.java	Updates test listener to implement WorkflowExecutionCompletableListener.
impl/core/src/test/java/io/serverlessworkflow/impl/MediumPriorityListener.java	Updates test listener to implement WorkflowExecutionCompletableListener.
impl/core/src/test/java/io/serverlessworkflow/impl/LowestPriorityListener.java	Updates test listener to implement WorkflowExecutionCompletableListener.
impl/core/src/main/java/io/serverlessworkflow/impl/lifecycle/WorkflowExecutionListenerAdapter.java	Adds adapter from legacy listener to completable listener.
impl/core/src/main/java/io/serverlessworkflow/impl/lifecycle/WorkflowExecutionCompletableListener.java	Adds new async listener interface with default completed futures.
impl/core/src/main/java/io/serverlessworkflow/impl/lifecycle/LifecycleEventsUtils.java	Refactors event publishing to return a combined CompletableFuture.
impl/core/src/main/java/io/serverlessworkflow/impl/executors/AbstractTaskExecutor.java	Composes task lifecycle events into the task execution future chain.
impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowMutableInstance.java	Composes workflow start/completion events into the workflow execution future chain.
impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowApplication.java	Stores completable listeners, adapts legacy listeners loaded via ServiceLoader, updates builder APIs.
impl/core/src/main/java/io/serverlessworkflow/impl/SchedulerListener.java	Migrates scheduler listener to completable listener callback shape.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gmunozfe]

Looks good to me, works like a charm, nice fixing @fjtirado !