Skip to content

feat: add --wait flag to compute-envs delete#593

Open
robsyme wants to merge 3 commits intomasterfrom
fd7252-delete-wait
Open

feat: add --wait flag to compute-envs delete#593
robsyme wants to merge 3 commits intomasterfrom
fd7252-delete-wait

Conversation

@robsyme
Copy link
Copy Markdown
Member

@robsyme robsyme commented Mar 30, 2026

Summary

  • Adds a --wait boolean flag to tw compute-envs delete
  • After the DELETE API call returns, polls describeComputeEnv() until the CE is fully removed (404) or enters ERRORED state
  • Backoff: 2s initial, +1s per poll, max 120s (matches existing waitStatus pattern)
  • Prints progress dots (suppressed in JSON output mode)
  • Prints error message if CE enters ERRORED state

Context

Forge CE deletion is async since Dec 2025 (commit be99dcf9b9). The CE stays in DELETING status for ~2 minutes while AWS resources are cleaned up. Tools like seqerakit that delete-then-recreate CEs (on_exists: overwrite) need to wait for deletion to complete before creating the replacement.

Related: FD-7252, platform#10680

Test plan

  • testDeleteWaitHappyPath: DELETE 204 -> poll DELETING -> poll 404 -> exit 0
  • testDeleteWaitErrored: DELETE 204 -> poll ERRORED -> exit 1
  • Existing delete tests unchanged (testDelete, testDeleteInvalidAuth, testDeleteNotFound)

🤖 Generated with Claude Code

robsyme added 3 commits March 30, 2026 16:53
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Signed-off-by: Rob Syme <rob.syme@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Signed-off-by: Rob Syme <rob.syme@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Signed-off-by: Rob Syme <rob.syme@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant