Open
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3414 +/- ##
=======================================
Coverage 59.24% 59.25%
=======================================
Files 2110 2110
Lines 174149 174198 +49
=======================================
+ Hits 103175 103221 +46
- Misses 62041 62042 +1
- Partials 8933 8935 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Note
Medium Risk
Touches EVM state snapshot/journaling and rollback semantics (code, nonce, address mappings), which is consensus-critical and easy to get subtly wrong despite added tests.
Overview
Fixes snapshot rollback correctness in
xevm/stateby journaling key existence (not just values) for code and nonce updates, and by capturing/restoring the Sei<->EVM address mapping state created implicitly bySetCode.Rollback now uses shared
restoreCode/restoreNoncehelpers to precisely delete or recreate underlying KV entries (including code hash/size) and to clean up newly-created accounts/mappings. Separately,SetStatecontinues to dedupe journal entries on no-op writes but still writes the value through to the backing store.Adds regression tests covering mapping cleanup on code revert, preserving explicit empty code, reverting nonce back to “absent”,
CreateAccountrestoring absent nonce state, and verifying no-opSetStatestill performs a store write.Reviewed by Cursor Bugbot for commit 5c4446e. Bugbot is set up for automated code reviews on this repo. Configure here.