You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
EVM keeper used to mirror mempool state to be able to track highest nonce per account in mempool, which required passing callbacks from EVM keeper to TxMempool. Additionally it passed a IsPending callback, so that TxMempool could verify if evm transaction is ready to be executed on demand. This pr is simplifying the execution flow as follows:
made Application take a LocalClient instead of generic Client, so that new Application -> Tendermint calls do not require exposing new network rpcs
added EVMNonce and EVMBalance methods to LocalClient so that Tendermint can evaluate evm tx eligibility without callbacks needed
removed callbacks from ResponseCheckTxV2
made GetTransactionCount EVM RPC call Tendermint to evaluate the high nonce in mempool per account instead of mirroring mempool state.
Additionally
marked some config fields as deprecated, given that only local tendermint node is supported
changed type of evm address fields from hex encoded string to common.Address
removed expirationIndex, since it was just mirroring txStore.
❌ Patch coverage is 45.61129% with 347 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.14%. Comparing base (c7e729a) to head (e345b59).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EVM keeper used to mirror mempool state to be able to track highest nonce per account in mempool, which required passing callbacks from EVM keeper to TxMempool. Additionally it passed a IsPending callback, so that TxMempool could verify if evm transaction is ready to be executed on demand. This pr is simplifying the execution flow as follows:
Additionally