migration code cleanup#3407
Merged
cody-littley merged 43 commits intomainfrom May 11, 2026
Merged
Conversation
added 30 commits
April 28, 2026 13:24
added 12 commits
May 5, 2026 09:28
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3407 +/- ##
==========================================
+ Coverage 59.03% 59.16% +0.13%
==========================================
Files 2105 2106 +1
Lines 173300 173989 +689
==========================================
+ Hits 102312 102945 +633
- Misses 62104 62121 +17
- Partials 8884 8923 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
blindchaser
reviewed
May 7, 2026
| newDone = true | ||
| } | ||
| // Write to the old DB first, then the new DB. If the old-DB write | ||
| // fails we do not touch the new DB; this gives the caller a clean |
blindchaser
reviewed
May 7, 2026
| // contract that an old-DB write failure must prevent the new-DB write | ||
| // from being attempted. This is the partner correctness invariant to | ||
| // the "old DB first, then new DB" ordering: if the old-DB write blew | ||
| // up, we want a clean recovery point with the new DB still untouched |
Contributor
There was a problem hiding this comment.
what happens when the old db succeeds and new db fails
Contributor
Author
There was a problem hiding this comment.
The composite store layer is responsible for atomic updates between memIAVL and flatKV. When it starts up, it compares the version of each, and rolls one or the other back if they are not the same.
blindchaser
approved these changes
May 8, 2026
Kbhat1
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR contains various minor cleanup work that I've accumulated in my migration feature branch. I'm opening a PR for this so that the actual migration business logic can be reviewed without noise from a bunch of minor changes.
The largest change in this PR is the removal of multi-threaded fanout within the router code. This introduced some race conditions, and was very much a premature optimization anyways. This also allowed for the
ctxarguments to be removed from the router API.Testing performed to validate your change
unit tests