Optimize conflict-heavy EVM transfer execution#3405
Open
codchen wants to merge 1 commit into
Open
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3405 +/- ##
==========================================
- Coverage 59.24% 59.24% -0.01%
==========================================
Files 2110 2110
Lines 174149 174188 +39
==========================================
+ Hits 103175 103197 +22
- Misses 62041 62053 +12
- Partials 8933 8938 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
1 task
7623f7b to
0203fa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is split out from #3376 so the behavior changes can be reviewed separately from logging and stress tooling.
Test Plan
go test ./app ./utils/helpers ./app/ante ./x/evm/ante ./x/evm/typesNote
Medium Risk
Changes EVM DeliverTx signature/association flow, account mapping/migration behavior, and block execution routing between OCC and sequential paths; mistakes here could affect transaction validity, nonce/account state, or block processing performance.
Overview
Improves EVM tx processing in conflict-heavy scenarios by reusing already-computed
msg.Derivedsender data during DeliverTx, avoiding repeated signature recovery and adding explicit invalid-pubkey rejection.Adjusts address association to reuse an existing empty “cast” auth account (preserving account number/sequence) when safe, and skips balance migration when the cast address and Sei address are identical.
Adds a heuristic to detect large blocks (>=64) of simple EVM value transfers to a single recipient and forces sequential execution for those blocks (including disabling Giga OCC in that case) to avoid OCC retry churn.
Reviewed by Cursor Bugbot for commit 0203fa4. Bugbot is set up for automated code reviews on this repo. Configure here.