Refactor getContextDiffNumbered with separate Nothing equation#27
Open
ninioArtillero wants to merge 1 commit into
Open
Refactor getContextDiffNumbered with separate Nothing equation#27ninioArtillero wants to merge 1 commit into
getContextDiffNumbered with separate Nothing equation#27ninioArtillero wants to merge 1 commit into
Conversation
9029104 to
617f5f5
Compare
617f5f5 to
83c5688
Compare
getContextDiffNumbered with separate Nothing equationgetContextDiffNumbered with separate Nothing equation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an extra equation for the
Nothingcase lifts the burden of handling it atdoPreffixanddoSuffix, resulting in clearer code and avoiding unnecessary traversals ofgetGroupedDiff a0 b0output. This is possible because theNothingcase resulted in all elements being preserved, particularly noBothbeing split, and thus producing a single hunk with the output ofgetGroupedDiff.It is also of note that calls to
maxwere already no-ops asdroptruncates negatives to 0.