Conversation
lsf37
force-pushed
the
spdx-license-headers
branch
from
41580c8 to
b0e1922
Compare
Member
Author
|
The link check failure is unrelated and being fixed in seL4/ci-actions#392 |
wom-bat
approved these changes
Mar 16, 2025
Member
wom-bat
left a comment
wom-bat
left a comment
There was a problem hiding this comment.
Looks good to me. One very minor change (it's not necessary, but would be nice) change http to https for the website URI
Adds SPDX license headers as required by the Foundation, and change README license to CC-BY-SA-4.0. This also strips trailing whitespace. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Exclude bash_mq_completion from bashisms check, because it explicitly is for bash. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
lsf37
force-pushed
the
spdx-license-headers
branch
from
b0e1922 to
0d83580
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SPDX license headers as required by the Foundation.
The license is GPL-2.0-only as was indicated by the main LICENSE file in the repo before (now moved to the LICENSES directory). A few of the workflow files are BSD-2-Clause, that's why that license exists in there, but the code is all GPL-2.0-only.
I have changed the README license to CC-BY-SA-4.0, because GPL is not really appropriate for documentation. I hope that is Ok.
The commit also strips trailing whitespace from some files so that the corresponding check will not fail when those files are edited.