feat: add Conjugate app download data UI (#564)#603
Conversation
Shows all supported languages alphabetically instead of only installed keyboard languages, using shared components with the keyboard app. Signed-off-by: Mounil Kanakhara <mounilkankhara@gmail.com>
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
54e228c to
f63221f
Compare
Signed-off-by: Mounil Kanakhara <mounilkankhara@gmail.com>
andrewtavis
left a comment
There was a problem hiding this comment.
All's looking great here, @Mounil2005! Thanks for adding in the screen :) So cool to have the conjugate app be at this level already 😊
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR adds the download data UI for the Scribe-Conjugate app.
Files changed:
app/src/main/java/be/scri/ui/screens/download/ConjugateDownloadDataScreen.kt(new) - A new screen that displays all 8 supported languages (English, French, German, Italian, Portuguese, Russian, Spanish, Swedish) sorted alphabetically. Unlike the keyboard app's download screen which only shows installed keyboards, this screen always shows all languages. It reuses shared components (LanguageItemComp,CircleClickableItemComp,SwitchableItemComp) and shared data classes (DownloadActions,CheckUpdateActions,LanguageItem) from the keyboard app. There is no empty state and no translation source language confirmation dialog, as these are keyboard-specific features.app/src/main/java/be/scri/App.kt- Added a new"conjugate_download_data"navigation route wired toConjugateDownloadDataScreen, and updatedConjugateScreen'sonNavigateToDownloadDatato use this route instead of the keyboard app's"download_data"route.Related issue