You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My initial reaction is that NonZero types could go the same way atomic types did (#24), into its own crate. However, the explicit links with unsigned Div<NonZero> etc. do make it seem appropriate to add here. But if we're going to do that, I would like to try to be complete about it as well, with something like trait NonZeroPrimitiveInteger and Signed/Unsigned sub types, and all their possible methods from the standard library as well.
Are you up for that? I could also experiment with that idea myself.
Zeroable has a nice connection to the standard library ZeroablePrimitive -- although that's unstable and could even be renamed. I suppose that can't be helped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds NonZero as a type in PrimativeInteger