feat: add is_initialized to check if the context has been set#4
Open
Frando wants to merge 1 commit intorust-mobile:masterfrom
Open
feat: add is_initialized to check if the context has been set#4Frando wants to merge 1 commit intorust-mobile:masterfrom
Frando wants to merge 1 commit intorust-mobile:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
fn is_initialized() -> boolto check whether aAndroidContexthas been initialized. It is an addition only so fully backwards compatible and could be released as a patch release.Motivation: I have library code that has an optional JNI path with a non-JNI fallback. Ideally, I want the library to be usable both by apps/crates that use
ndk_contextand by ones that don't for whatever reason. For the latter I want to use my non-JNI fallback path. However, currently it is not possible to branch on whetherndk_contexthas been initialized. The only function to get the context panics if it hasn't been initialized. With this addition, I can do the check and then branch between my JNI path (which requiresndk_context) and the non-JNI path.