fail loudly on unsized by-ref invariants#1644
Merged
bjorn3 merged 2 commits intorust-lang:mainfrom Apr 16, 2026
Merged
Conversation
bjorn3
reviewed
Apr 14, 2026
Contributor
Author
|
Is “copy sized prefix when writing from |
bjorn3
reviewed
Apr 14, 2026
bjorn3
approved these changes
Apr 15, 2026
0xmuon
changed the title
Contributor
Author
|
Done! |
bjorn3
pushed a commit
that referenced
this pull request
Apr 16, 2026
replace the remaining todo!() paths for unsized by-ref values in src/value_and_place.rs with explicit bug!() failures. This makes invariant violations fail loudly instead of panicking via unfinished code paths,and without claiming support for unsized by-ref handling that is not actually implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace the remaining
todo!()paths for unsized by-ref values insrc/value_and_place.rswith explicitbug!()failures.This makes invariant violations fail loudly instead of panicking via unfinished code paths,and without claiming support for unsized by-ref handling that is not actually implemented.