resolve: Module-related refactorings#156406
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 10, 2026
resolve: Module-related refactorings
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (9c31e24): comparison URL. Overall result: no relevant changes - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesResults (primary 2.3%, secondary -6.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 499.454s -> 498.907s (-0.11%) |
rustbot
removed
the
S-waiting-on-perf
Contributor
Author
|
Perf-neutral. |
nnethercote
approved these changes
May 11, 2026
Contributor
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 11, 2026
resolve: Module-related refactorings Extracted parts of rust-lang#156362 that don't require splitting `(Local,Extern)ModuleData` into separate data structures. - Some `expect_local` assertions are added - Methods that need to exist on all of `Module` and `(Local,Extern)Module` are implemented for `ModuleData` - Methods that need to exist on `ModuleKind` are moved to `ModuleKind` - Some unnecessary complicated logic using `graph_root` is simplified - `glob_importers` are filled and used only for local modules. - Some unnecessary logic is skipped for extern modules in `resolve_ident_in_module_non_globs_unadjusted` - Module construction functions are cleaned up - `module_to_string` is simplified r? @nnethercote
rust-bors Bot
pushed a commit
that referenced
this pull request
May 11, 2026
…uwer Rollup of 13 pull requests Successful merges: - #156437 (`rust-analyzer` subtree update) - #156357 (tests: ip*_properties: avoid parsing the IP over and over again) - #156389 (prepare fs tests for miri) - #156147 (Update ICU4X to 2.2) - #156375 (kernel_copy tests: properly join background threads) - #156406 (resolve: Module-related refactorings) - #155946 (Refuse to push changes with a dirty git client) - #156282 (Update `sysinfo` version to `0.39.0`) - #156372 (remove allows_weak_linkage target spec flag) - #156384 (Remove some dead code for dumping MIR for a single DefId) - #156392 (Improve doc comments for f32::ceil() and f32::floor()) - #156411 (bootstrap: Don't panic on `x install --set build.extended=true`) - #156426 (Fix unwanted "Available on XX-bit only" in libcore integers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted parts of #156362 that don't require splitting
(Local,Extern)ModuleDatainto separate data structures.expect_localassertions are addedModuleand(Local,Extern)Moduleare implemented forModuleDataModuleKindare moved toModuleKindgraph_rootis simplifiedglob_importersare filled and used only for local modules.resolve_ident_in_module_non_globs_unadjustedmodule_to_stringis simplifiedr? @nnethercote