Skip to content

resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets#156284

Open
petrochenkov wants to merge 2 commits intorust-lang:mainfrom
petrochenkov:kvak2
Open

resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets#156284
petrochenkov wants to merge 2 commits intorust-lang:mainfrom
petrochenkov:kvak2

Conversation

@petrochenkov
Copy link
Copy Markdown
Contributor

Fixes #156264.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 7, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 7, 2026

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 18 candidates

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 7, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@petrochenkov
Copy link
Copy Markdown
Contributor Author

The proper fix requires landing #149195 first, and may potentially cause some performance issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E0365 newly triggers on pub(crate) reexports (cannot be re-exported outside)

3 participants