Use `all_impls` instead of handrolling it by oli-obk · Pull Request #156148 · rust-lang/rust

oli-obk · 2026-05-04T15:37:36Z

just found this while looking at other things

lqd

Good catch.

r=me w/ nit

lqd · 2026-05-04T15:50:35Z

-                                        .collect::<Vec<_>>();
+                                if !types.is_empty() {
+                                    let len = types.len();
                                    let post = if types.len() > 9 {


might as well

Suggested change

let post = if types.len() > 9 {

let post = if len > 9 {

lqd · 2026-05-04T15:50:50Z

-                                        .collect::<Vec<_>>();
+                                if !types.is_empty() {
+                                    let len = types.len();
                                    let post = if types.len() > 9 {


might as well

Suggested change

let post = if types.len() > 9 {

let post = if len > 9 {

lqd · 2026-05-04T15:51:10Z

-                                        .collect::<Vec<_>>();
+                                if !types.is_empty() {
+                                    let len = types.len();
                                    let post = if types.len() > 9 {


might as well

Suggested change

let post = if types.len() > 9 {

let post = if len > 9 {

lqd

Good catch.

r=me w/ nit

View changes since this review

lqd · 2026-05-04T15:53:44Z

Great job at idempotency GH 👍

rustbot · 2026-05-05T15:11:55Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

oli-obk · 2026-05-05T15:12:08Z

@bors r=lqd rollup

rust-bors · 2026-05-05T15:12:16Z

📌 Commit 6865172 has been approved by lqd

It is now in the queue for this repository.

Use `all_impls` instead of handrolling it just found this while looking at other things

Rollup of 12 pull requests Successful merges: - #155341 (generic_const_args: allow paths to non type consts) - #156062 (Added command-line argument support for `wasm32-wali-linux-musl`) - #156159 ([AIX] add -bdbg:namedsects:ss link arg) - #156174 (Wasm: remove implicit `__heap_base`/`__data_end` exports) - #156186 (fix: remap ci-llvm debug paths via `-ffile-prefix-map`) - #156193 (port `rustc_ast*` crates from `box_` to `deref_patterns`) - #156201 (Don't run ui-fulldeps tests twice in stage 1) - #155808 (Always use `ConstFn` context for `const` closures) - #156105 (interpret: correctly deal with repr(transparent) enums) - #156148 (Use `all_impls` instead of handrolling it) - #156156 (Adjust getMCSubtargetInfo signature for LLVM 23+) - #156205 (move generalization test)

Rollup of 15 pull requests Successful merges: - #151122 (fix: more descriptive error message for enum to integer) - #155341 (generic_const_args: allow paths to non type consts) - #156062 (Added command-line argument support for `wasm32-wali-linux-musl`) - #156159 ([AIX] add -bdbg:namedsects:ss link arg) - #156174 (Wasm: remove implicit `__heap_base`/`__data_end` exports) - #156186 (fix: remap ci-llvm debug paths via `-ffile-prefix-map`) - #156193 (port `rustc_ast*` crates from `box_` to `deref_patterns`) - #156201 (Don't run ui-fulldeps tests twice in stage 1) - #155808 (Always use `ConstFn` context for `const` closures) - #156105 (interpret: correctly deal with repr(transparent) enums) - #156148 (Use `all_impls` instead of handrolling it) - #156156 (Adjust getMCSubtargetInfo signature for LLVM 23+) - #156170 (add known-bug test for coroutine 'static-yields-non-'static unsoundness (#144442)) - #156195 (Move tests codegen) - #156205 (move generalization test)

Rollup merge of #156148 - oli-obk:all_impls, r=lqd Use `all_impls` instead of handrolling it just found this while looking at other things

Rollup of 15 pull requests Successful merges: - rust-lang/rust#151122 (fix: more descriptive error message for enum to integer) - rust-lang/rust#155341 (generic_const_args: allow paths to non type consts) - rust-lang/rust#156062 (Added command-line argument support for `wasm32-wali-linux-musl`) - rust-lang/rust#156159 ([AIX] add -bdbg:namedsects:ss link arg) - rust-lang/rust#156174 (Wasm: remove implicit `__heap_base`/`__data_end` exports) - rust-lang/rust#156186 (fix: remap ci-llvm debug paths via `-ffile-prefix-map`) - rust-lang/rust#156193 (port `rustc_ast*` crates from `box_` to `deref_patterns`) - rust-lang/rust#156201 (Don't run ui-fulldeps tests twice in stage 1) - rust-lang/rust#155808 (Always use `ConstFn` context for `const` closures) - rust-lang/rust#156105 (interpret: correctly deal with repr(transparent) enums) - rust-lang/rust#156148 (Use `all_impls` instead of handrolling it) - rust-lang/rust#156156 (Adjust getMCSubtargetInfo signature for LLVM 23+) - rust-lang/rust#156170 (add known-bug test for coroutine 'static-yields-non-'static unsoundness (rust-lang/rust#144442)) - rust-lang/rust#156195 (Move tests codegen) - rust-lang/rust#156205 (move generalization test)

Kobzol · 2026-05-12T11:54:01Z

@rust-timer build 5d9c694

Testing for #156217.

rust-timer · 2026-05-12T14:38:11Z

Finished benchmarking commit (5d9c694): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-7.7%, -0.5%]	5
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.4%, 1.6%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	31
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	21
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.1%]	31

Bootstrap: 493.455s -> 496.472s (0.61%)
Artifact size: 394.43 MiB -> 394.47 MiB (0.01%)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 4, 2026

lqd approved these changes May 4, 2026

View reviewed changes

Use all_impls instead of handrolling it

6865172

oli-obk force-pushed the all_impls branch from 757838e to 6865172 Compare May 5, 2026 15:11

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2026

jhpratt added a commit to jhpratt/rust that referenced this pull request May 5, 2026

Rollup merge of rust-lang#156148 - oli-obk:all_impls, r=lqd

3400675

Use `all_impls` instead of handrolling it just found this while looking at other things

jhpratt mentioned this pull request May 5, 2026

Rollup of 12 pull requests #156207

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request May 5, 2026

Rollup merge of rust-lang#156148 - oli-obk:all_impls, r=lqd

aff6ef8

Use `all_impls` instead of handrolling it just found this while looking at other things

jhpratt mentioned this pull request May 5, 2026

Rollup of 12 pull requests #156213

Closed

jhpratt mentioned this pull request May 6, 2026

Rollup of 15 pull requests #156217

Merged

rust-bors Bot merged commit 74d6b21 into rust-lang:main May 6, 2026
10 of 11 checks passed

rustbot added this to the 1.97.0 milestone May 6, 2026

rust-timer added a commit that referenced this pull request May 6, 2026

Unrolled build for #156148

5d9c694

Rollup merge of #156148 - oli-obk:all_impls, r=lqd Use `all_impls` instead of handrolling it just found this while looking at other things

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use `all_impls` instead of handrolling it#156148

Use `all_impls` instead of handrolling it#156148
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
oli-obk:all_impls

oli-obk commented May 4, 2026

Uh oh!

lqd left a comment •

edited by rustbot

Loading

Uh oh!

lqd May 4, 2026

Uh oh!

lqd May 4, 2026

Uh oh!

lqd May 4, 2026

Uh oh!

lqd left a comment •

edited by rustbot

Loading

Uh oh!

lqd commented May 4, 2026

Uh oh!

rustbot commented May 5, 2026

Uh oh!

oli-obk commented May 5, 2026

Uh oh!

rust-bors Bot commented May 5, 2026

Uh oh!

Uh oh!

Kobzol commented May 12, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

oli-obk commented May 4, 2026

Uh oh!

lqd left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lqd May 4, 2026

Choose a reason for hiding this comment

Uh oh!

lqd May 4, 2026

Choose a reason for hiding this comment

Uh oh!

lqd May 4, 2026

Choose a reason for hiding this comment

Uh oh!

lqd left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lqd commented May 4, 2026

Uh oh!

rustbot commented May 5, 2026

Uh oh!

oli-obk commented May 5, 2026

Uh oh!

rust-bors Bot commented May 5, 2026

Uh oh!

Uh oh!

Kobzol commented May 12, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 12, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lqd left a comment •

edited by rustbot

Loading

lqd left a comment •

edited by rustbot

Loading