Rollup of 6 pull requests by matthiaskrgr · Pull Request #136823 · rust-lang/rust

matthiaskrgr · 2025-02-10T15:38:29Z

Successful merges:

adding autodiff tests #136419 (adding autodiff tests)
ci: upgrade to crosstool-ng 1.27.0 #136628 (ci: upgrade to crosstool-ng 1.27.0)
resolve llvm-config path properly on cross builds #136681 (resolve llvm-config path properly on cross builds)
Update compiler-builtins to 0.1.146 #136714 (Update compiler-builtins to 0.1.146)
rustc_middle: parallel: TyCtxt: remove "unsafe impl DynSend/DynSync" #136731 (rustc_middle: parallel: TyCtxt: remove "unsafe impl DynSend/DynSync")
Disable DWARF in linker options for i686-unknown-uefi #136791 (Disable DWARF in linker options for i686-unknown-uefi)

Failed merges:

improve host/cross target checking #136767 (improve host/cross target checking)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Exposes the error function so we can expose this in the standard library [1]. [1]: rust-lang/compiler-builtins#753

We don't need to "short circuit trait resolution", because DynSend and DynSync are auto traits and thus coinductive

Signed-off-by: onur-ozkan <work@onurozkan.dev>

This fixes an lld warning: > warning: linker stderr: rust-lld: section name .debug_frame is longer > than 8 characters and will use a non-standard string table See https://reviews.llvm.org/D69594 for details of where the warning was added. This warning only occurs with the i686 UEFI target, not x86_64 or aarch64. The x86_64 target uses an LLVM target of `x86_64-unknown-windows` and aarch64 uses `aarch64-unknown-windows`, but i686 uses `i686-unknown-windows-gnu` (note the `-gnu`). See comments in `i686_unknown_uefi.rs` for details of why. The `.debug_frame` section should not actually be needed; UEFI targets provide a separate PDB file for debugging. Disable DWARF (and by extension the `.debug_frame` section) by passing `/DEBUG:NODWARF` to lld. Tested with: export RUSTC_LOG=rustc_codegen_ssa::back::link=info cargo +stage1 build --release --target i686-unknown-uefi

Signed-off-by: onur-ozkan <work@onurozkan.dev>

…kan,jieyouxu adding autodiff tests I'd like to get started with upstreaming some tests, even though I'm still waiting for an answer on how to best integrate the enzyme pass. Can we therefore temporarily support the -Z llvm-plugins here without too much effort? And in that case, how would that work? I saw you can do remapping, e.g. `rust-src-base`, but I don't think that will give me the path to libEnzyme.so. Do you have another suggestion? Other than that this test simply checks that the derivative of `x*x` is `2.0 * x`, which in this case is computed as `%0 = fadd fast double %x.0.val, %x.0.val` (I'll add a few more tests and move it to an autodiff folder if we can use the -Z flag) r? ``@jieyouxu`` Locally at least `-Zllvm-plugins=${PWD}/build/x86_64-unknown-linux-gnu/enzyme/build/Enzyme/libEnzyme-19.so` seems to work if I copy the command I get from x.py test and run it manually. However, running x.py test itself fails. Tracking: - rust-lang#124509 Zulip discussion: https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Enzyme.20build.20changes

…imulacrum ci: upgrade to crosstool-ng 1.27.0 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl try-job: dist-powerpc64le-linux

resolve `llvm-config` path properly on cross builds Fixes rust-lang#132926 try-job: x86_64-mingw-2

Update `compiler-builtins` to 0.1.146 Exposes the error function so we can expose this in the standard library [1]. [1]: rust-lang/compiler-builtins#753

…22, r=SparrowLii rustc_middle: parallel: TyCtxt: remove "unsafe impl DynSend/DynSync" rustc_middle: parallel: TyCtxt: remove "unsafe impl DynSend/DynSync" We don't need to "short circuit trait resolution", because DynSend and DynSync are auto traits and thus coinductive cc "Parallel Rustc Front-end" rust-lang#113349 r? SparrowLii ``@rustbot`` label: +WG-compiler-parallel (rustbot sometimes ignores me and doesn't attach labels on my behalf. rustbot banned me?)

…f, r=jieyouxu Disable DWARF in linker options for i686-unknown-uefi This fixes an lld warning: > warning: linker stderr: rust-lld: section name .debug_frame is longer than 8 characters and will use a non-standard string table See https://reviews.llvm.org/D69594 for details of where the warning was added. This warning only occurs with the i686 UEFI target, not x86_64 or aarch64. The x86_64 target uses an LLVM target of `x86_64-unknown-windows` and aarch64 uses `aarch64-unknown-windows`, but i686 uses `i686-unknown-windows-gnu` (note the `-gnu`). See comments in `i686_unknown_uefi.rs` for details of why. The `.debug_frame` section should not actually be needed; UEFI targets provide a separate PDB file for debugging. Disable DWARF (and by extension the `.debug_frame` section) by passing `/DEBUG:NODWARF` to lld. Tested with: ``` export RUSTC_LOG=rustc_codegen_ssa::back::link=info cargo +stage1 build --release --target i686-unknown-uefi ``` This issue was originally raised here: rust-lang#119286 (comment). See also rust-lang#136096. It was suggested to file an LLVM bug, but I don't think LLVM is actually doing anything wrong as such. CC `@dvdhrm` `@jyn514` let me know if you have any feedback on this approach

matthiaskrgr · 2025-02-10T15:38:50Z

@bors r+ rollup=never p=5

bors · 2025-02-10T15:38:52Z

📌 Commit 4fff320 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-02-10T18:12:19Z

⌛ Testing commit 4fff320 with merge 4bb6ec0...

bors · 2025-02-10T21:07:16Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 4bb6ec0 to master...

rust-timer · 2025-02-10T21:09:23Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#136419	adding autodiff tests	`c77f95cca49d47cf626812ed15077fc7a34f9764` (link)
#136628	ci: upgrade to crosstool-ng 1.27.0	`991a54d6fec61c5af6d5d001bfe7286d951dac44` (link)
#136681	resolve `llvm-config` path properly on cross builds	`2b4301d8a5871c18f9e4c9222a9f98be5101379e` (link)
#136714	Update `compiler-builtins` to 0.1.146	`dd56c29856da911723e67e58b78ca3958092a332` (link)
#136731	rustc_middle: parallel: TyCtxt: remove "unsafe impl DynSend…	`100799e99e91844c1e77150c8ee70583db8bdc32` (link)
#136791	Disable DWARF in linker options for i686-unknown-uefi	`92466339fe7a7e00a47932deee55ac45c2113e43` (link)

previous master: 4b293d9927

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-02-10T22:24:56Z

Finished benchmarking commit (4bb6ec0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.6%, secondary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[3.4%, 3.8%]	3
Regressions ❌ (secondary)	3.1%	[1.7%, 7.2%]	19
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.6%	[3.4%, 3.8%]	3

Cycles

Results (primary 2.3%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.3%, -2.0%]	2
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.713s -> 785.578s (0.88%)
Artifact size: 348.25 MiB -> 348.28 MiB (0.01%)

klensy · 2025-02-11T09:36:51Z

max-rss regressed?

ZuseZ4 and others added 21 commits February 1, 2025 21:51

adding first autodiff test

335151f

fix fwd-mode autodiff case

70b9ba3

ci: upgrade to crosstool-ng 1.27.0

ed2823c

get tests to work without -Z/-C flags

8f87e80

Update compiler-builtins to 0.1.146

38a8302

Exposes the error function so we can expose this in the standard library [1]. [1]: rust-lang/compiler-builtins#753

update enzyme core to provide c bindings

3a44180

simplify autodiff tests to run without local path

6345b59

fix autodiff perf by running the enzyme opt pass before autodiff

a6e5527

fix non-enzyme builds

21d0961

rustc_middle: parallel: TyCtxt: remove "unsafe impl DynSend/DynSync"

8eba29a

We don't need to "short circuit trait resolution", because DynSend and DynSync are auto traits and thus coinductive

resolve llvm-config path properly on cross builds

4b8b18f

Signed-off-by: onur-ozkan <work@onurozkan.dev>

move second opt run to lto phase and cleanup code

1221cff

remove outdated *First autodiff variants for higher-order ad

061abbc

add coverage for llvm-config path resolution

e07e335

Signed-off-by: onur-ozkan <work@onurozkan.dev>

Rollup merge of rust-lang#136628 - heiher:crosstool-ng-1.27, r=Mark-S…

111726c

…imulacrum ci: upgrade to crosstool-ng 1.27.0 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl try-job: dist-powerpc64le-linux

Rollup merge of rust-lang#136681 - onur-ozkan:132926, r=jieyouxu

2becd0b

resolve `llvm-config` path properly on cross builds Fixes rust-lang#132926 try-job: x86_64-mingw-2

Rollup merge of rust-lang#136714 - tgross35:update-builtins, r=tgross35

ad92b85

Update `compiler-builtins` to 0.1.146 Exposes the error function so we can expose this in the standard library [1]. [1]: rust-lang/compiler-builtins#753

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 10, 2025

bors merged commit 4bb6ec0 into rust-lang:master Feb 10, 2025

rustbot added this to the 1.86.0 milestone Feb 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests#136823

Rollup of 6 pull requests#136823
bors merged 21 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-vp20mk1

matthiaskrgr commented Feb 10, 2025

Uh oh!

matthiaskrgr commented Feb 10, 2025

Uh oh!

bors commented Feb 10, 2025

Uh oh!

bors commented Feb 10, 2025

Uh oh!

bors commented Feb 10, 2025

Uh oh!

rust-timer commented Feb 10, 2025

Uh oh!

rust-timer commented Feb 10, 2025

Uh oh!

klensy commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Conversation

matthiaskrgr commented Feb 10, 2025

Uh oh!

matthiaskrgr commented Feb 10, 2025

Uh oh!

bors commented Feb 10, 2025

Uh oh!

bors commented Feb 10, 2025

Uh oh!

bors commented Feb 10, 2025

Uh oh!

rust-timer commented Feb 10, 2025

Uh oh!

rust-timer commented Feb 10, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

klensy commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants