feat: Add skribe-fuzz binary for LibAFL fuzzer to the nix derivation#80
feat: Add skribe-fuzz binary for LibAFL fuzzer to the nix derivation#80gtrepta wants to merge 11 commits into
Conversation
e4f104a to
eb7a153
Compare
Instead of trying to manage linker flags across different platforms.
41fa7f4 to
a557e8a
Compare
8368f21 to
9655a0b
Compare
There was a problem hiding this comment.
Please add integration or smoke tests for the skribe-fuzz part using the nix derivation. It could be that the binary builds properly, but fails at runtime for a variety of reasons.
E.g., you can run integration tests like in stable-mir-json, see https://github.com/runtimeverification/stable-mir-json/blob/885ab4a9f6dd1b5416b57e914082fbb341c89f97/.github/workflows/test.yml#L212 and https://github.com/runtimeverification/stable-mir-json/blob/885ab4a9f6dd1b5416b57e914082fbb341c89f97/nix/test/integration.nix .
.github/workflows/test.yaml:120 already, e.g., runs a smoke test of skribe using the nix build on both Linux and MacOS.
Other than this and the single comment, this looks really good to me.
| lib.cleanSource (nix-gitignore.gitignoreSourcePure [ | ||
| ../../.gitignore | ||
| "result*" | ||
| "target/" | ||
| ] ../../skribe-fuzz-rs | ||
| ) |
There was a problem hiding this comment.
Also add the .gitignore in the skribe-fuzz-rs directory. This will also allow you to leave out target here.
| lib.cleanSource (nix-gitignore.gitignoreSourcePure [ | |
| ../../.gitignore | |
| "result*" | |
| "target/" | |
| ] ../../skribe-fuzz-rs | |
| ) | |
| lib.cleanSource (nix-gitignore.gitignoreSourcePure [ | |
| ../../.gitignore | |
| ../../skribe-fuzz-rs/.gitignore | |
| "result*" | |
| ] ../../skribe-fuzz-rs | |
| ) |
| }; | ||
| packages = rec { | ||
| inherit (pkgs) skribe; | ||
| inherit (pkgs) skribe skribe-fuzz; |
There was a problem hiding this comment.
Btw, is skribe-fuzz also meant to be run standalone without skribe? Because if that is the case, we would probably want to add the skribe-fuzz binary in skribe.
skribe-kdistderivation that bothskribe-fuzzandskribedepend onskribe-fuzzderivation for the fuzzer binary