Fix/dropdown race condition#749
Open
fIa5h wants to merge 2 commits intoruilisi:masterfrom
Open
Conversation
Try to add origin space back to make pr diff cleaner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a "Cannot update a component while rendering a different component" error and a race condition that occurs when selecting an item from the dropdown.
Changes:
selectedstate array.setSelectedcall inside thesetContextrecipe (which was causing the React warning).dataVerificationDropDownList = false) when in single-select mode, ensuring it unmounts immediately after selection.The original code mutated the state directly and failed to close the dropdown in single-select mode:
The patched code clones the array and handles unmounting:
AFAIK
setContextuses Immer to produce the next state. The callback function passed to it is effectively a reducer. Calling a React state setter (setSelected) inside a reducer or state updater function is a violation of React's purity rules and explains the 'Cannot update component while rendering another' error.