Replaced SSF by numfmt (ECMA-376 support)#482
Replaced SSF by numfmt (ECMA-376 support)#482juanparati wants to merge 2 commits intoruilisi:masterfrom
Conversation
|
@juanparati Thanks. This is a big change. I need to look into this deeply to ensure it doesn't break anything. |
471416d to
829cacb
Compare
|
Hi @juanparati , fortune-sheet has added its own extra changes in ssf implementation (that's why we aren't importing the package but created a file ssf.js). The changes are from line 1700-1825 in ssf.js. I'm not sure in numfmt takes in account the 万 chinese character. |
This would be nice to have |
|
@Kreijstal fs uses a modified version of ssf, and these changes using numfmt wont work for us directly. |
|
@juanparati maybe you can upstream the changes from ssf to the repo? |
I replaced SSF by numfmt the reasons what I did that is because SSF doesn't support custom localization features. To replace SSF by numfmt it will open the door to use custom localization features like number formats, currencies, etc.
Numfmt supports by default Chinese (traditional and simplified), Spanish and English among other locales.