Skip to content

Replaced SSF by numfmt (ECMA-376 support)#482

Open
juanparati wants to merge 2 commits intoruilisi:masterfrom
juanparati:refactor-replace-ssf-2-numfmt
Open

Replaced SSF by numfmt (ECMA-376 support)#482
juanparati wants to merge 2 commits intoruilisi:masterfrom
juanparati:refactor-replace-ssf-2-numfmt

Conversation

@juanparati
Copy link
Copy Markdown

I replaced SSF by numfmt the reasons what I did that is because SSF doesn't support custom localization features. To replace SSF by numfmt it will open the door to use custom localization features like number formats, currencies, etc.

Numfmt supports by default Chinese (traditional and simplified), Spanish and English among other locales.

@gazedreamily gazedreamily requested a review from zyc9012 September 7, 2023 11:16
@zyc9012
Copy link
Copy Markdown
Contributor

zyc9012 commented Sep 16, 2023

@juanparati Thanks. This is a big change. I need to look into this deeply to ensure it doesn't break anything.

@zyc9012 zyc9012 force-pushed the master branch 3 times, most recently from 471416d to 829cacb Compare April 5, 2024 08:58
@Corbe30
Copy link
Copy Markdown
Contributor

Corbe30 commented Nov 20, 2024

Hi @juanparati , fortune-sheet has added its own extra changes in ssf implementation (that's why we aren't importing the package but created a file ssf.js). The changes are from line 1700-1825 in ssf.js. I'm not sure in numfmt takes in account the 万 chinese character.

@sanchit3008

@Kreijstal
Copy link
Copy Markdown
Contributor

I replaced SSF by numfmt the reasons what I did that is because SSF doesn't support custom localization features. To replace SSF by numfmt it will open the door to use custom localization features like number formats, currencies, etc.

Numfmt supports by default Chinese (traditional and simplified), Spanish and English among other locales.

This would be nice to have

@sanchit3008
Copy link
Copy Markdown
Contributor

sanchit3008 commented Nov 25, 2024

@Kreijstal fs uses a modified version of ssf, and these changes using numfmt wont work for us directly.

@Kreijstal
Copy link
Copy Markdown
Contributor

@juanparati maybe you can upstream the changes from ssf to the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants