Fix ruby-head-wasm-wasi builds on Ruby head with host dump_ast#630
Merged
kateinoigakukun merged 1 commit intoruby:mainfrom Mar 22, 2026
Merged
Fix ruby-head-wasm-wasi builds on Ruby head with host dump_ast#630kateinoigakukun merged 1 commit intoruby:mainfrom
kateinoigakukun merged 1 commit intoruby:mainfrom
Conversation
Pass the host-built dump_ast alongside --with-baseruby so cross builds do not try to execute the target-side wasm dump_ast while generating .rbinc files on current Ruby head. Also declare dump_ast_path in RBS and document why the configure argument is needed.
ledsun
force-pushed
the
fix-issue-629-dump-ast
branch
from
c6edc92 to
e4a524c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dump_astto cross builds alongside--with-baserubydump_astduring.rbincgeneration on current Ruby headdump_ast_pathin RBS and document why the configure argument is neededTesting
bundle exec rake check:typeCloses #629.