Fix pvalue display when --pvalue is not being passed.#492
Merged
eightbitraptor merged 1 commit intomainfrom Mar 17, 2026
Merged
Fix pvalue display when --pvalue is not being passed.#492eightbitraptor merged 1 commit intomainfrom
eightbitraptor merged 1 commit intomainfrom
Conversation
The p-value indicators should only be included if --pvalue is passed to the run_benchmarks.rb script
k0kubun
added a commit
to k0kubun/ruby-bench
that referenced
this pull request
Mar 25, 2026
The ljust padding in format_ratio added trailing spaces to reserve room for significance symbols, but these spaces were then stripped by rstrip in the table formatter's format_row, causing the last column to lose its right-alignment. This was exposed by ruby#492 which made pval nil when --pvalue is not passed, meaning the significance symbol is always empty in the common case, yet the ljust padding was still applied and then stripped. Remove the ljust padding entirely and let the table formatter handle column alignment, restoring the original format_ratio logic.
k0kubun
added a commit
that referenced
this pull request
Mar 25, 2026
The ljust padding in format_ratio added trailing spaces to reserve room for significance symbols, but these spaces were then stripped by rstrip in the table formatter's format_row, causing the last column to lose its right-alignment. This was exposed by #492 which made pval nil when --pvalue is not passed, meaning the significance symbol is always empty in the common case, yet the ljust padding was still applied and then stripped. Remove the ljust padding entirely and let the table formatter handle column alignment, restoring the original format_ratio logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The p-value indicators should only be included if --pvalue is passed to the run_benchmarks.rb script