test_broken_bignum: stop using fork + waitpid#962
Merged
byroot merged 2 commits intoruby:masterfrom Mar 26, 2026
Merged
Conversation
k0kubun
force-pushed
the
test-broken-bignum
branch
2 times, most recently
from
ab1cd66 to
03bbab2
Compare
Member
|
I don't see |
Member
|
Ah, I remember now, |
The raw fork + Process.waitpid2 pattern causes a SEGV on i686-linux in ruby/ruby CI. The crash occurs in waitpid_blocking_no_SIGCHLD going through the 32-bit vdso, which is a Ruby VM / kernel interaction issue unrelated to the json gem itself. Replace the fork-based approach with an in-process test that temporarily patches Integer#to_s and restores it via ensure. This avoids the fork SEGV on i686, works under valgrind (assert_separately doesn't), and is guarded to only run on CRuby (not JRuby/TruffleRuby) where the C extension behavior being tested exists.
byroot
force-pushed
the
test-broken-bignum
branch
2 times, most recently
from
ec64ecb to
4ae952a
Compare
Member
Author
|
Sorry, I changed the patch after failing JRuby and TruffleRuby jobs, so the PR description was outdated. Thank you for taking care of this 🙏 |
byroot
force-pushed
the
test-broken-bignum
branch
from
4ae952a to
79883fd
Compare
Member
|
Welcome, thanks for finding and reporting that problem ❤️ |
byroot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The raw fork + Process.waitpid2 pattern causes a SEGV on i686-linux in ruby/ruby CI. The crash occurs in waitpid_blocking_no_SIGCHLD going through the 32-bit vdso, which is a Ruby VM / kernel interaction issue unrelated to the json gem itself.
example failure: https://github.com/ruby/ruby/actions/runs/23563393907/job/68608786831