fix: ParseError Display panic on zero-length filter errors at end of input (#975)#976
Open
rustyprimus wants to merge 1 commit into
Open
fix: ParseError Display panic on zero-length filter errors at end of input (#975)#976rustyprimus wants to merge 1 commit into
rustyprimus wants to merge 1 commit into
Conversation
…input (rsonquery#975) When a filter expression fails at end of input the parser emits a SyntaxError with len=0. The display code computed end_idx as start_idx + len - 1, producing an inverted byte span (end < start). This caused an arithmetic underflow in formatter::width_of_char_span when it subtracted the higher accumulated width from the lower one. - error/display.rs: clamp end_idx to start_idx when len == 0, in both display() and generate_notes() - tests/error_snapshots.rs: add regression snapshots for "$.a[?" and "$[?@.b =="
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a filter expression fails at end of input the parser emits a SyntaxError with len=0. The display code computed end_idx as start_idx + len - 1, producing an inverted byte span (end < start). This caused an arithmetic underflow in formatter::width_of_char_span when it subtracted the higher accumulated width from the lower one.
Issue
Resolves: #975