Skip to content

fix: update wokingham form selectors and add playwright path#2102

Open
InertiaUK wants to merge 1 commit into
robbrad:masterfrom
InertiaUK:fix/wokingham-new-form-ids
Open

fix: update wokingham form selectors and add playwright path#2102
InertiaUK wants to merge 1 commit into
robbrad:masterfrom
InertiaUK:fix/wokingham-new-form-ids

Conversation

@InertiaUK
Copy link
Copy Markdown
Contributor

Summary

  • Council updated their Drupal form with new element IDs (removed -csv suffix)
  • Old: edit-postcode-search-csv, edit-address-options-csv, edit-find-collections-csv
  • New: edit-postcode-search, edit-address-options, edit-show-collection-dates
  • Collection dates now in span.card__date (not p tags)
  • Adds Playwright as primary execution path (faster, bypasses cookie overlay issues)
  • Selenium fallback maintained for environments without Playwright

Testing

  • RG40 2HR + house 90: 3 bins returned (Household waste, Recycling, Garden waste)
  • Both Playwright and Selenium paths verified working

Council updated their Drupal form - all element IDs changed from
*-csv suffix to base names (edit-postcode-search, edit-address-options,
edit-show-collection-dates). Collection dates now render in
span.card__date instead of p tags.

Adds Playwright path as primary (faster, more reliable) with Selenium
fallback for environments without Playwright installed. Both paths
use the corrected selectors and date extraction.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 30, 2026

Warning

Review limit reached

@InertiaUK, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 28 minutes and 43 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cf3b9267-b0d6-40af-9ccf-9ab6929c4b54

📥 Commits

Reviewing files that changed from the base of the PR and between 8ecf878 and 2085715.

📒 Files selected for processing (1)
  • uk_bin_collection/uk_bin_collection/councils/WokinghamBoroughCouncil.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.67%. Comparing base (8ecf878) to head (2085715).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2102   +/-   ##
=======================================
  Coverage   86.67%   86.67%           
=======================================
  Files           9        9           
  Lines        1141     1141           
=======================================
  Hits          989      989           
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant