remove unsafe casts and non-null assertions#331
Open
evelant wants to merge 1 commit intorive-app:mainfrom
Open
remove unsafe casts and non-null assertions#331evelant wants to merge 1 commit intorive-app:mainfrom
evelant wants to merge 1 commit intorive-app:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed all of the unsafe casts and non-null assertions that were causing crashes. Replaced them with error logging. Rive should no longer hard crash apps due to simple issues like being unmounted when an event fires.