Nicer hints and errors in rill query#9118
Merged
begelundmuller merged 2 commits intomainfrom Mar 25, 2026
Merged
Conversation
pjain1
approved these changes
Mar 25, 2026
|
|
||
| // Print rows with warning if the default limit was reached. | ||
| ch.PrintQueryResponse(res) | ||
| if !cmd.Flags().Changed("limit") && len(res.Data) == limit { |
Member
There was a problem hiding this comment.
nit: very rare case but what if there were actually only 100 rows in the dataset, may be not worth handling.
Contributor
Author
There was a problem hiding this comment.
Yeah I'm okay with not handling that since the caller didn't specify an explicit limit and this is only a warning. If the caller retries with an explicit limit, the warning goes away :)
begelundmuller
added a commit
that referenced
this pull request
Mar 30, 2026
* Nicer hints and errors in `rill query` * QA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist: