feat(fleet): support registryAliases#42045
Open
k0da wants to merge 4 commits intorenovatebot:mainfrom
Open
Conversation
viceice
reviewed
Mar 22, 2026
lib/modules/manager/fleet/extract.ts
Outdated
Comment on lines
+94
to
+97
| if (!doc.repo) { | ||
| dep.skipReason = 'placeholder-url'; | ||
| return dep; | ||
| } |
lib/modules/manager/fleet/extract.ts
Outdated
| } | ||
|
|
||
| const alias = config.registryAliases?.[doc.repo]; | ||
| if (doc.repo && alias) { |
Member
There was a problem hiding this comment.
Suggested change
| if (doc.repo && alias) { | |
| if (alias) { |
repo is never undefined here
Member
There was a problem hiding this comment.
inline to test and use codeBlock
| describe('extractPackageFile()', () => { | ||
| it('should return null if empty content', () => { | ||
| const result = extractPackageFile('', 'fleet.yaml'); | ||
| const result = extractPackageFile('', 'fleet.yaml', noConfig); |
Member
There was a problem hiding this comment.
Suggested change
| const result = extractPackageFile('', 'fleet.yaml', noConfig); | |
| const result = extractPackageFile('', 'fleet.yaml', {}); |
should work to and simplifies tests
Support registry aliases for pull through internal regitry case Signed-off-by: Dinar Valeev <k0da@opensuse.org>
Signed-off-by: Dinar Valeev <k0da@opensuse.org>
Author
|
@viceice Hi, thanks for review. I've addresses all review comments. Could you please review again. |
Signed-off-by: Dinar Valeev <k0da@opensuse.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support registry aliases for pull through internal regitry case
Changes
This implements registryAliases info
fleetmanager. Forociandhttpbased helm reposContext
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: