fix(mdxish): render and parse tables without <tr>#1411
Open
maximilianfalco wants to merge 4 commits intonextfrom
Open
fix(mdxish): render and parse tables without <tr>#1411maximilianfalco wants to merge 4 commits intonextfrom
maximilianfalco wants to merge 4 commits intonextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What does this PR do?
Fixes
<Table>components where<thead>or<tbody>cells aren't wrapped in an explicit<tr>. This is valid HTML that browsers render fine, but MDXish was producing empty/broken tables because the conversion logic only looked for cells inside<tr>elements.Two fixes in two files:
mdxish-tables.ts— The phrasing-only renderer now checks whether a<thead>/<tbody>section has<tr>children. If not, it collects cells directly from the section and treats them as a single implicit row.mdxish-jsx-to-mdast.ts— ThetransformTableMDAST converter normalizes bare cells into an implicit<tr>wrapper before processing, so the existing row-based logic works unchanged.🧪 QA tips
Paste this into a doc using the MDXish editor and verify it renders a table with headers "Hi" / "World" and body cells "Hello" / "Globe":
<table>still works as before<tr>wrappers are unaffected📸 Screenshot or Loom
Screen.Recording.2026-03-30.at.17.08.11.mov