Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 9 9
Lines 1443 1443
=======================================
Hits 1440 1440
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s formatting setup to rely on Ruff formatting rather than Black, aligning configuration and CI naming with the intended formatter.
Changes:
- Remove the
[tool.black]configuration frompyproject.toml. - Update the CI workflow step name to reflect that formatting checks are performed via
ruff format --check.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pyproject.toml |
Removes Black config; retains Ruff config that now effectively governs formatting. |
.github/workflows/ci.yml |
Renames the formatting step to accurately describe the Ruff formatter check being run. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [tool.ruff] | ||
| line-length = 120 |
There was a problem hiding this comment.
[tool.ruff] is configured with line-length = 120, but isort is still configured with line_length = 119 (see the [tool.isort] section further down in this file). Now that formatting is handled by Ruff, these mismatched line-length settings can lead to inconsistent wrapping behavior across tools; it’s best to align on a single value (e.g., set both to 120, or keep both at 119 to preserve existing formatting).
|
|
||
| [tool.ruff] | ||
| line-length = 120 | ||
| fix = true |
There was a problem hiding this comment.
fix = true makes ruff check run in fix mode by default. Since CI runs ruff check temba_client without --no-fix, this can cause the linter step to mutate files in CI (and potentially mask issues depending on exit-code behavior). Consider setting fix = false in config and enabling fixes only in local/dev commands, or add --no-fix in CI (and optionally --exit-non-zero-on-fix where fixes are allowed).
| fix = true | |
| fix = false |
No description provided.