fix(soldeer): ignore .envrc and .prettierignore on publish#214
Conversation
The bump step in package-release.yaml runs cargo release without --no-publish, which makes it try to publish to crates.io. CARGO_REGISTRY_TOKEN is only set on the separate Publish to crates.io step further down, so the bump step fails with no token found, please run cargo login. Add --no-publish so the bump step only bumps the version + commits. The dedicated Publish step does the upload with the token set. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Both tracked, both trip soldeer's check_dotfiles warning. In CI there is no TTY, so the confirmation prompt fails with "not connected" and the publish errors out. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughCI workflow and ignore patterns updated: cargo release command flags modified to remove ChangesConfiguration Updates
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
|
Tip For best results, initiate chat on the files or code changes. SIZE=S |
Summary
.envrcand.prettierignoreto.soldeerignore.check_dotfileswarning. CI has no TTY for the confirmation prompt, so soldeer errors witherror during IO operation for "": not connectedand the publish fails (run 25800427603).Test plan
forge soldeer push rain-math-float~0.1.0 --dry-runlocally — zip no longer contains either file.Summary by CodeRabbit