build(deps): bump lodash from 4.17.21 to 4.18.1 in /catalog#4801
Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
Closed
build(deps): bump lodash from 4.17.21 to 4.18.1 in /catalog#4801dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.18.1. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.18.1) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.18.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Author
|
Looks like lodash is updatable in another way, so this is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps lodash from 4.17.21 to 4.18.1.
Release notes
Sourced from lodash's releases.
Commits
cb0b9b9release(patch): bump main to 4.18.1 (#6177)75535f5chore: prune stale advisory refs (#6170)62e91bcdocs: remove n_ Node.js < 6 REPL note from README (#6165)59be2derelease(minor): bump to 4.18.0 (#6161)af63457fix: broken tests for _.template 879aaa91073a76fix: linting issues879aaa9fix: validate imports keys in _.templatefe8d32efix: block prototype pollution in baseUnset via constructor/prototype traversal18ba0a3refactor(fromPairs): use baseAssignValue for consistent assignment (#6153)b819080ci: add dist sync validation workflow (#6137)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Greptile Summary
This PR bumps
lodashfrom4.17.21to4.18.1in thecatalogpackage, addressing two security vulnerabilities included in the4.18.0release:constructor/prototypepath traversal in_.unset/_.omitimportskeys in_.template, an incomplete fix for CVE-2021-23337The change is confined to
catalog/package.json(version range bump) andcatalog/package-lock.json(resolved version and integrity hash). No source files were modified.Notable observation: Two nested, dev-only lodash copies introduced by graphql tooling remain on older versions in the lock file:
@graphql-codegen/plugin-helpers→lodash@4.17.23(dev)@graphql-tools/url-loader→lodash@4.17.21(dev)Because both are
dev: true, they are excluded from the production bundle and pose no runtime risk to end users.Confidence Score: 5/5
Safe to merge — purely a security patch dependency bump with no source changes.
The PR only modifies lock and manifest files to upgrade lodash from 4.17.21 to 4.18.1, which ships two confirmed security fixes. The integrity hash is present, the change is generated by Dependabot, and no application logic is touched. The remaining older lodash copies are dev-only and excluded from the production bundle.
No files require special attention, but
catalog/package-lock.jsoncontains two dev-only nested lodash copies still on older versions (4.17.21 and 4.17.23) — worth tracking for a future cleanup if those transitive dev dependencies are ever updated.Important Files Changed
lodashupdated from^4.17.21to^4.18.1— straightforward and correct.lodashresolved to4.18.1with updated integrity hash; two dev-only nested copies (@graphql-codegen/plugin-helpers→ 4.17.23,@graphql-tools/url-loader→ 4.17.21) remain on older, unpatched versions but are excluded from the production build.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["catalog (production)"] -->|"lodash@4.18.1 ✅"| L1["lodash 4.18.1\n(CVEs patched)"] B["@graphql-codegen/plugin-helpers\n(dev only)"] -->|"nested override"| L2["lodash 4.17.23\n(dev, not bundled)"] C["@graphql-tools/url-loader\n(dev only)"] -->|"nested override"| L3["lodash 4.17.21\n(dev, not bundled)"] style L1 fill:#22c55e,color:#fff style L2 fill:#f59e0b,color:#fff style L3 fill:#f59e0b,color:#fffReviews (1): Last reviewed commit: "build(deps): bump lodash from 4.17.21 to..." | Re-trigger Greptile