Skip to content

docs: Benchling metadata field documentation#4748

Merged
drernie merged 5 commits intomasterfrom
docs-benchling-metadata
Apr 10, 2026
Merged

docs: Benchling metadata field documentation#4748
drernie merged 5 commits intomasterfrom
docs-benchling-metadata

Conversation

@drernie
Copy link
Copy Markdown
Member

@drernie drernie commented Mar 3, 2026

Summary

Documents the specific metadata fields the Benchling webhook synchronizes into each Quilt package. A customer needed this detail to design a metadata-validating workflow — knowing the exact field names, types, and formats lets them write reliable workflow schemas against the package metadata.

Change

docs/examples/benchling.md — Replaces the vague "(experiment IDs, authors, etc.)" with an explicit field list:

  • authors (list)
  • created_at (ISO timestamp)
  • creator (e.g. "First Last <user_id@ent_XXXX>")
  • display_id (e.g. "EXP0000XXXXXX")
  • entry_id (e.g. "etr_XXXXXX")
  • files (list)
  • modified_at (ISO timestamp)
  • web_url (URL string)

docs/examples/quiltsync.md — Adds the missing quiltsync-push.png image reference in the Committing Changes section.

🤖 Generated with Claude Code

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Comment thread docs/examples/benchling.md Outdated
Comment thread docs/examples/quiltsync.md
@drernie drernie force-pushed the docs-benchling-metadata branch from 9432283 to 8b4d123 Compare March 3, 2026 16:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.62%. Comparing base (8369dae) to head (cad45a4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4748   +/-   ##
=======================================
  Coverage   45.62%   45.62%           
=======================================
  Files         831      831           
  Lines       33597    33597           
  Branches     5727     5727           
=======================================
  Hits        15328    15328           
  Misses      16264    16264           
  Partials     2005     2005           
Flag Coverage Δ
api-python 93.14% <ø> (ø)
catalog 19.52% <ø> (ø)
lambda 96.63% <ø> (ø)
py-shared 98.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@drernie drernie self-assigned this Mar 3, 2026
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@drernie drernie requested a review from kevinemoore March 3, 2026 17:30
@drernie drernie enabled auto-merge March 3, 2026 17:30
@drernie drernie requested a review from QuiltSimon March 4, 2026 17:09
kevinemoore
kevinemoore previously approved these changes Mar 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Benchling webhook documentation to explicitly enumerate which Benchling metadata fields are synchronized into each Quilt package, so downstream workflows can validate package metadata against known keys and formats.

Changes:

  • Replaces the vague “(experiment IDs, authors, etc.)” text with an explicit list of synced metadata fields and their expected formats.
  • Adds inline examples for identifier-like fields (e.g., display_id, entry_id) and timestamp fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/examples/benchling.md Outdated
Comment thread docs/examples/benchling.md Outdated
Comment thread docs/examples/benchling.md Outdated
@sir-sigurd
Copy link
Copy Markdown
Member

@drernie ping

drernie and others added 2 commits April 10, 2026 07:13
Indent metadata field list as sub-items under "Synchronizes metadata"
bullet, add missing quiltsync-push.png image reference, and update PR
description to match actual bullet-list format.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@drernie drernie requested a review from kevinemoore April 10, 2026 17:11
Copy link
Copy Markdown
Contributor

@QuiltSimon QuiltSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drernie drernie added this pull request to the merge queue Apr 10, 2026
Merged via the queue into master with commit b6048c8 Apr 10, 2026
46 checks passed
@drernie drernie deleted the docs-benchling-metadata branch April 10, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants