Enhance fastrpc_test for multi-domain and multi-PD execution by anankulk · Pull Request #406 · qualcomm-linux/qcom-linux-testkit

anankulk · 2026-04-16T16:00:08Z

Summary

This PR enhances fastrpc_test by expanding test coverage from a single DSP domain to runtime discovery and validation of all supported DSP domains.
The change improves coverage on platforms with multiple DSPs while preserving compatibility with legacy single-domain execution.

Changes

Runtime DSP domain discovery

Discover available DSP domains at runtime using get_remoteproc_by_firmware() with dt_has_remoteproc_fw() as fallback
Remove reliance on a fixed default domain
Canonicalize firmware names (cdsp0→cdsp, gdsp0→gpdsp0, gdsp1→gpdsp1)

Expanded domain support

Add support for CDSP1, GPDSP0, and GPDSP1
Covers domains 4, 5, and 6

Domain-aware PD execution

Enforce PD execution rules based on domain capabilities:
- ADSP / MDSP / SDSP: signed PD only
- CDSP / CDSP1 / GPDSP: signed and unsigned PDs
Automatically select supported PD modes per domain
Honour FASTRPC_UNSIGNED_PD env var with correct priority: --unsigned-pd CLI > FASTRPC_UNSIGNED_PD env > --pd-mode

Result tracking and reporting

Track pass/fail and subtest counts per domain and per PD mode during execution
Remove post-run log reparsing — all counts accumulated in RESULTS_TRACKER during run loop
Print a tabular summary per domain and PD mode

SoC-specific handling

Skip QRB2210 entirely — FastRPC not supported
Filter GPDSP0/GPDSP1 (domains 5/6) for QCS9075 and QCS8275
SoC identified via /sys/devices/soc0/machine

Behavior

Default behavior

Test all discovered DSP domains with supported PD modes

Legacy behavior

Preserve single-domain execution via:
--domain-mode single --domain <N>

Maintenance

Remove unused pick_default_domain() helper
Rename USER_PD → UNSIGNED_PD across YAML params, CLI flags and env vars
Fix SKIP paths to exit with status 0
Resolve ShellCheck warnings (SC2002, SC2317, SC2086, SC2188)
Fix trailing whitespace and missing EOF newline
Update YAML metadata and run.sh usage documentation

Expected Sample Output: (qcs9100-ride-sx)

smuppand

changed defaults are not truly backward compatible
YAML wrapper in the changed hunk still uses the older masked pattern
the new no-domain skip path exits 1 after writing SKIP

Please address the workflow issues - https://github.com/qualcomm-linux/qcom-linux-testkit/actions/runs/24520486149/job/71764753535?pr=406

smuppand · 2026-04-17T04:26:09Z

@@ -40,6 +40,8 @@ VERBOSE=0
 USER_PD_FLAG=0 # default: -U 0 (system/signed PD)
 CLI_DOMAIN=""
 CLI_DOMAIN_NAME=""
+DOMAIN_MODE="all-supported" # ENHANCED: default to all-supported
+PD_MODE="both" # ENHANCED: default to both PDs


Same recommendation as for the YAML: either preserve old defaults here, or explicitly document that the default execution model is changing.

Addressed by documenting the default execution model change in run.sh usage function with "Enhanced Test Coverage" section and domain selection priority explanation.

smuppand · 2026-04-17T04:26:41Z

+if [ -z "$DOMAINS_TO_TEST" ]; then
+    log_skip "$TESTNAME SKIP - no mapped/supported domains detected"
+    echo "$TESTNAME : SKIP" >"$RESULT_FILE"
+    exit 1


After writing SKIP, exit 0

Addressed by changing all SKIP conditions to exit 0 instead of exit 1

smuppand

Could you please test this in Lava and share the jobs as a reference once the changes are applied?

@bhargav0610 @qcom-anilyada The current run.sh script modifies the default behavior, and fastrpc is designed to change it intentionally. Please take note of this.

smuppand · 2026-04-21T17:13:46Z

Kodiak - https://lava.infra.foundries.io/scheduler/job/184817
RB8 - https://lava.infra.foundries.io/scheduler/job/184820
RB1 - https://lava.infra.foundries.io/scheduler/job/184821

smuppand · 2026-05-19T09:49:57Z

@anankulk Please fix the workflow errors https://github.com/qualcomm-linux/qcom-linux-testkit/actions/runs/24723885995/job/72363028941

smuppand · 2026-05-20T04:47:45Z

@anankulk Fix the workflow issues

anankulk · 2026-05-20T05:32:06Z

Acknowledged the comment and updated the patch with the required fix.

smuppand

Please do squashing/cleaning the 5 commits

smuppand · 2026-05-20T06:38:52Z

+    esac
+
+    pattern="${LOG_ROOT}/${dom_name}_${pd_tag}_iter*.out"
+    for iter_file in $pattern; do


The final summary still reparses ${LOG_ROOT}/${domain}_${pd}_iter*.out files to compute subtest totals. The earlier request and PR description say results should be tracked during the main run loop instead of reparsing logs. Please either track subtest totals during each iteration and store them in RESULTS_TRACKER, or update the PR description if this reparsing is intentionally retained only for subtest summary.

smuppand · 2026-05-20T06:39:38Z

  FASTRPC_DOMAIN_NAME=adsp|... Named domain; CLI wins.
-  FASTRPC_USER_PD=0|1 Sets PD (-U value). CLI --user-pd overrides to 1.
+  FASTRPC_UNSIGNED_PD=0|1 Sets PD (-U value). CLI --unsigned-pd overrides to 1.


documents FASTRPC_UNSIGNED_PD, but requested_pds() does not consume it. Please either implement FASTRPC_UNSIGNED_PD handling or remove it from usage text.

Acknowledged.

- Runtime domain discovery via get_remoteproc_by_firmware() with dt_has_remoteproc_fw() as fallback - Support for CDSP1, GPDSP0, GPDSP1 in addition to existing domains - Canonicalize firmware names (cdsp0->cdsp, gdsp0->gpdsp0, gdsp1->gpdsp1) - Domain-aware PD execution (ADSP/MDSP/SDSP: signed only; CDSP/CDSP1/GPDSP: both signed and unsigned) - Rename USER_PD -> UNSIGNED_PD in YAML params, flags and env vars - Honour FASTRPC_UNSIGNED_PD env var in requested_pds() - Track subtest counts during execution; remove log reparsing in finalize - Tabular per-domain/per-PD summary with aligned columns - SoC blacklist: skip QRB2210 entirely; filter GPDSP0/GPDSP1 for QCS9075 and QCS8275 - Fix SC2002: replace cat pipe with direct redirect for tr - Fix all SKIP/FAIL exit paths to exit 0 for LAVA .res consumption Signed-off-by: Anand Kulkarni <anankulk@qti.qualcomm.com>

smuppand · 2026-05-21T09:58:17Z

@anankulk

Here are the jobs on different targets, please check:

smuppand requested changes Apr 17, 2026

View reviewed changes

Comment thread Runner/suites/Multimedia/CDSP/fastrpc_test/fastrpc_test.yaml Outdated

smuppand requested review from abbajaj806, bhargav0610 and qcom-anilyada April 17, 2026 16:20

smuppand added the enhancement New feature or request label Apr 18, 2026

smuppand requested changes Apr 20, 2026

View reviewed changes

Comment thread Runner/suites/Multimedia/CDSP/fastrpc_test/fastrpc_test.yaml Outdated

ekanshibu reviewed Apr 20, 2026

View reviewed changes

Comment thread Runner/suites/Multimedia/CDSP/fastrpc_test/fastrpc_test.yaml Outdated

Comment thread Runner/suites/Multimedia/CDSP/fastrpc_test/fastrpc_test.yaml Outdated

anankulk force-pushed the fastrpc-multi-domain-test branch 3 times, most recently from 7797d7e to 43a4100 Compare April 21, 2026 06:46

anankulk force-pushed the fastrpc-multi-domain-test branch from 4afc121 to 8a1e3b3 Compare May 19, 2026 11:01

anankulk requested a review from smuppand May 19, 2026 12:14

anankulk force-pushed the fastrpc-multi-domain-test branch from 37e4d9f to 2c7b767 Compare May 19, 2026 12:47

anankulk force-pushed the fastrpc-multi-domain-test branch from 2c7b767 to 1a4877f Compare May 20, 2026 05:05

smuppand requested changes May 20, 2026

View reviewed changes

anankulk force-pushed the fastrpc-multi-domain-test branch from 1a4877f to 8b3b28b Compare May 21, 2026 05:24

Conversation

anankulk commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Runtime DSP domain discovery

Expanded domain support

Domain-aware PD execution

Result tracking and reporting

SoC-specific handling

Behavior

Default behavior

Legacy behavior

Maintenance

Uh oh!

smuppand left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

smuppand Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

anankulk Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

smuppand Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

anankulk Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smuppand commented Apr 21, 2026

Uh oh!

smuppand commented May 19, 2026

Uh oh!

smuppand commented May 20, 2026

Uh oh!

anankulk commented May 20, 2026

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

smuppand May 20, 2026

Choose a reason for hiding this comment

Uh oh!

smuppand May 20, 2026

Choose a reason for hiding this comment

Uh oh!

anankulk May 21, 2026

Choose a reason for hiding this comment

Uh oh!

smuppand commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anankulk commented Apr 16, 2026 •

edited

Loading

smuppand left a comment •

edited

Loading