wifi: ath12k: skip WoW path when no vif is present#1221
Open
MilanoPipo wants to merge 1 commit into
Open
Conversation
When userspace sets WoWLAN configuration (e.g. iw phy0 wowlan enable magic-packet) and then suspends with all interfaces administratively down, mac80211 still calls drv_suspend() with a wowlan config. The existing handler issues WMI_WOW_ENABLE_CMDID to firmware that has no active vdev, leaving it in an undefined state. On resume the device is inaccessible: MHI fails to leave M3, the PCIe link is unrecoverable and every subsequent WMI command times out. Detect the empty arvifs list at op_suspend entry and return 1, which makes mac80211 fall back to its normal radio-off path (cfg80211_shutdown_all_interfaces) and skips the WoW handshake entirely. Signed-off-by: Yingying Tang <yintang@qti.qualcomm.com>
qcomlnxci
requested review from
a team and
miaoqing-quic
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When userspace sets WoWLAN configuration (e.g. iw phy0 wowlan enable magic-packet) and then suspends with all interfaces administratively down, mac80211 still calls drv_suspend() with a wowlan config. The existing handler issues WMI_WOW_ENABLE_CMDID to firmware that has no active vdev, leaving it in an undefined state. On resume the device is inaccessible: MHI fails to leave M3, the PCIe link is unrecoverable and every subsequent WMI command times out.
Detect the empty arvifs list at op_suspend entry and return 1, which makes mac80211 fall back to its normal radio-off path (cfg80211_shutdown_all_interfaces) and skips the WoW handshake entirely.