Skip to content

arm64: dts: qcom: lemans: add AEST error nodes#1215

Open
umang-chheda wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs9100from
umang-chheda:lemans-edac-dt
Open

arm64: dts: qcom: lemans: add AEST error nodes#1215
umang-chheda wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs9100from
umang-chheda:lemans-edac-dt

Conversation

@umang-chheda
Copy link
Copy Markdown

Add AEST RAS error source nodes for the Lemans SoC.

The DT describes a processor error source covering all CPU cores and a shared L3 cache error source for the cluster. These nodes model the hardware error reporting blocks and associated interrupts as required by the Arm AEST specification.

Co-developed-by: Faruque Ansari faruque.ansari@oss.qualcomm.com

@qcomlnxci qcomlnxci requested review from a team, idlethread, ndechesne and shashim-quic and removed request for a team May 25, 2026 11:26
Copy link
Copy Markdown
Collaborator

@shashim-quic shashim-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FROMLIST , Link: missing ?

Add AEST RAS error source nodes for the Lemans SoC.

The DT describes a processor error source covering all CPU cores and a
shared L3 cache error source for the cluster. These nodes model the
hardware error reporting blocks and associated interrupts as required
by the Arm AEST specification.

Link: https://lore.kernel.org/lkml/20260505-aest-devicetree-support-v1-7-d5d6ffacf0a5@oss.qualcomm.com/
Co-developed-by: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
Signed-off-by: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
Signed-off-by: Umang Chheda <umang.chheda@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team and shashim-quic and removed request for a team May 26, 2026 06:43
@umang-chheda
Copy link
Copy Markdown
Author

FROMLIST , Link: missing ?

@shashim-quic Ack, I have updated FROMLIST and link. Apologize I had missed this ...

@qlijarvis
Copy link
Copy Markdown

PR #1215 — validate-patch

PR: #1215

Verdict Issues Detailed Report
⚠️ 4 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/lkml/20260505-aest-devicetree-support-v1-7-d5d6ffacf0a5@oss.qualcomm.com/

  2. Lore link matches PR commits: Cannot verify — network restrictions prevented fetching lore patch for comparison

  3. Upstream patch status: Cannot verify — network restrictions prevented checking lore thread and git trees for acceptance/rejection signals

  4. PR present in qcom-next: No — searched qcom-next branch, no AEST-related commits found for lemans.dtsi; patch has not landed in qcom-next yet

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1215 - FROMLIST: arm64: dts: qcom: lemans: add AEST error nodes
Upstream commit: https://lore.kernel.org/lkml/20260505-aest-devicetree-support-v1-7-d5d6ffacf0a5@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL (network restrictions prevented full lore comparison)

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify - lore.kernel.org unreachable
Body preserves rationale Clear description of AEST RAS error nodes for Lemans SoC
Fixes tag present/correct N/A New feature addition, no Fixes tag needed
Authorship preserved FROMLIST: both authors present in Signed-off-by chain
Backport note (if applicable) N/A FROMLIST prefix, not a backport
Co-developed-by usage Appropriate - both Faruque Ansari and Umang Chheda co-authored

Diff

File Status Notes
arch/arm64/boot/dts/qcom/lemans.dtsi ⏭️ Cannot compare to lore - network restricted; local analysis shows clean addition of AEST nodes

Commit Message Structure Analysis

Prefix: FROMLIST:

  • Correct usage: indicates patch posted to mailing list but not yet merged
  • Lore link present and properly formatted

Authorship (FROMLIST rules):
Correct - For FROMLIST: commits:

  • From: shows Umang Chheda (PR submitter) ✅
  • Original co-author Faruque Ansari present in Signed-off-by: chain ✅
  • Both authors have Signed-off-by: tags ✅
  • Co-developed-by: used appropriately for genuine co-authorship ✅

Link tag: ✅ Present and properly formatted
Link: https://lore.kernel.org/lkml/20260505-aest-devicetree-support-v1-7-d5d6ffacf0a5@oss.qualcomm.com/

Body: ✅ Clear and descriptive

  • Explains what: "Add AEST RAS error source nodes for the Lemans SoC"
  • Explains purpose: DT describes processor error sources and L3 cache error sources
  • References specification: "Arm AEST specification"

Diff Content Analysis (Local Only)

Changes made:

  1. ✅ Added #include <dt-bindings/arm/aest.h> header
  2. ✅ Added aest parent node with proper DT structure
  3. ✅ Added 3 child nodes:
    • aest-processor-0: Global processor error source (PPI 0)
    • aest-l3-cluster0: Shared L3 cache cluster 0 (SPI 36)
    • aest-l3-cluster1: Shared L3 cache cluster 1 (SPI 21)

DT binding properties used:

  • compatible = "arm,aest" and "arm,aest-processor"
  • arm,num-records, arm,record-impl, arm,status-reporting, arm,addressing-mode
  • arm,processor-flags with AEST_PROC_GLOBAL and AEST_PROC_SHARED macros
  • Standard interrupt properties

Code quality: ✅ Clean, well-structured device tree additions

Issues

Network Restriction:
⚠️ Cannot fetch lore.kernel.org patch due to network restrictions in this environment. Unable to perform byte-level diff comparison or verify upstream patch status. The following checks could not be completed:

  • Exact diff comparison between PR and lore patch
  • Verification that all hunks match upstream
  • Upstream acceptance status (merged/pending/rejected)
  • Detection of any semantic changes or adaptations

Verdict

Based on available local analysis:

Commit message structure is correct for a FROMLIST: commit:

  • Proper prefix usage
  • Lore link present and formatted correctly
  • Authorship follows FROMLIST rules (both co-authors in Signed-off-by chain)
  • Co-developed-by used appropriately
  • Clear, descriptive body text

Diff appears clean (local inspection only):

  • Single file changed (lemans.dtsi)
  • Adds AEST device tree nodes
  • Proper DT syntax and structure
  • Uses appropriate macros from dt-bindings

⚠️ Cannot verify:

  • Whether PR diff exactly matches lore patch (network restricted)
  • Upstream community decision (ACKed/NACKed/Pending)
  • Whether this is the latest revision of the patch series

Recommendation:
The commit message structure and local diff analysis show no issues. However, manual verification is required to:

  1. Confirm the PR diff exactly matches the lore patch at the provided link
  2. Check if the upstream patch has been accepted, rejected, or is still under review
  3. Verify this is patch 7 of a series and that dependencies (patches 1-6) are satisfied

If network access becomes available, re-run validation with full lore comparison.

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/lkml/20260505-aest-devicetree-support-v1-7-d5d6ffacf0a5@oss.qualcomm.com/

  2. Lore link matches PR commits: Cannot verify — network restrictions prevented fetching lore patch for comparison

  3. Upstream patch status: Cannot verify — network restrictions prevented checking lore thread and git trees for acceptance/rejection signals

  4. PR present in qcom-next: No — searched qcom-next branch, no AEST-related commits found for lemans.dtsi; patch has not landed in qcom-next yet

@qlijarvis
Copy link
Copy Markdown

PR #1215 — checker-log-analyzer

PR: #1215
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26436770114

Checker Result Summary
Checker Result Summary
checkpatch 4 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Fatal: missing header file dt-bindings/arm/aest.h
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no C/H changes)
check-patch-compliance Passed
tag-check All 3 commits have valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1215 - FROMLIST: arm64: dts: qcom: lemans: add AEST error nodes
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26436770114
Target branch: tech/all/dt/qcs9100

Checker Result Summary
checkpatch 4 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Fatal: missing header file dt-bindings/arm/aest.h
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no C/H changes)
check-patch-compliance Passed
tag-check All 3 commits have valid FROMLIST: prefix

❌ checkpatch

Root cause: The patch introduces new DT compatible strings (arm,aest and arm,aest-processor) that are not documented in the kernel tree.

Failure details:

WARNING: DT compatible string "arm,aest" appears un-documented
#38: FILE: arch/arm64/boot/dts/qcom/lemans.dtsi:35:
+		compatible = "arm,aest";

WARNING: DT compatible string "arm,aest-processor" appears un-documented
#44: FILE: arch/arm64/boot/dts/qcom/lemans.dtsi:41:
+			compatible = "arm,aest-processor";

447a8c60edbdee59bce9a9f452a800a75ff5c373 total: 0 errors, 4 warnings, 0 checks, 53 lines checked

Fix: This is expected for a FROMLIST: patch. The DT binding YAML for AEST should be part of the upstream patch series. Verify that:

  1. The upstream series at https://lore.kernel.org/lkml/20260505-aest-devicetree-support-v1-7-d5d6ffacf0a5@oss.qualcomm.com/ includes the binding documentation
  2. If backporting to this tree, consider including the binding YAML from the upstream series

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git <base_sha>..447a8c60edbd

❌ dtb-check

Root cause: The patch includes <dt-bindings/arm/aest.h> but this header file does not exist in the tree, causing compilation failure.

Failure details:

In file included from ../arch/arm64/boot/dts/qcom/lemans-evk.dts:13:
../arch/arm64/boot/dts/qcom/lemans.dtsi:7:10: fatal error: dt-bindings/arm/aest.h: No such file or directory
    7 | #include <dt-bindings/arm/aest.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[4]: *** [../scripts/Makefile.dtbs:140: arch/arm64/boot/dts/qcom/lemans-evk.dtb] Error 1

Fix: The header file include/dt-bindings/arm/aest.h must be added to the tree. This should be part of the upstream AEST patch series. Options:

  1. Recommended: Cherry-pick or backport the header file from the upstream series (likely patch 1 or 2 of the series)
  2. Add the header file as a separate commit before this DTS patch
  3. Verify the upstream series order and ensure all dependencies are included

The header likely defines constants like AEST_PROC_GLOBAL and AEST_PROC_SHARED used in the DTS.

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/lemans-evk.dtb

Verdict

2 blockers must be fixed before merge:

  1. Critical: Add the missing include/dt-bindings/arm/aest.h header file. This is a hard build failure that prevents DTB compilation.

  2. Advisory: The checkpatch warnings about undocumented compatible strings are expected for a FROMLIST: patch, but verify that the upstream series includes the binding YAML (Documentation/devicetree/bindings/arm/aest.yaml or similar). If backporting the full series, include the binding documentation as well.

Recommended action: Review the upstream patch series at the Link URL to identify which patches provide:

  • The dt-bindings/arm/aest.h header (likely patch 1-3 of the series)
  • The binding YAML documentation (likely patch 4-6 of the series)

Include these dependencies in the PR before the DTS patch, maintaining the upstream patch order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants