Skip to content

Guard weight_dequant.args[1] access in _quantize_fused_conv_bias pass#19623

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
ethansfng:export-D105503056
May 18, 2026
Merged

Guard weight_dequant.args[1] access in _quantize_fused_conv_bias pass#19623
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
ethansfng:export-D105503056

Conversation

@ethansfng
Copy link
Copy Markdown
Contributor

Summary:
For models whose conv weight isn't wrapped in a dequantize_per_tensor/per_channel call weight_dequant.args has fewer than 2 elements and the access throws IndexError.

Adds a guard to prevent this error.

Differential Revision: D105503056

Summary:
For models whose conv weight isn't wrapped in a `dequantize_per_tensor/per_channel` call `weight_dequant.args` has fewer than 2 elements and the access throws `IndexError`.

Adds a guard to prevent this error.

Differential Revision: D105503056
@ethansfng ethansfng requested a review from kimishpatel as a code owner May 18, 2026 00:05
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 18, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19623

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit f0f1163 with merge base 824cbff (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 18, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 18, 2026

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105503056.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot merged commit d62addb into pytorch:main May 18, 2026
289 of 294 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants